Adding pylint
#349
Merged
Adding pylint
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
commented
Sep 10, 2024
| assert_never() | ||
| assert_never(opt) |
There was a problem hiding this comment.
@mskarlin fyi it looks like you didn't properly roll out assert_never
More just sharing for future reference
mskarlin
reviewed
Sep 10, 2024
mskarlin
reviewed
Sep 10, 2024
|
This is sort of a draft. Some of this is going to go away with |
|
Okay, it's ready for review |
mskarlin
approved these changes
Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
pylintinto CI, suppresses a few more errors, and manually fixes all errors that came up