Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing MemoryAgent and timeouts on ldp agents #375

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Testing MemoryAgent and timeouts on ldp agents #375

merged 7 commits into from
Sep 13, 2024

Conversation

jamesbraza
Copy link
Collaborator

I also took the time to clean up agents.main a bit

@jamesbraza jamesbraza added the enhancement New feature or request label Sep 11, 2024
@jamesbraza jamesbraza self-assigned this Sep 11, 2024
whitead
whitead reviewed Sep 11, 2024
View reviewed changes
tests/test_agents.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 12, 2024
@jamesbraza jamesbraza force-pushed the testing-ldp-more branch 4 times, most recently from 8845617 to 4769bf9 Compare September 12, 2024 20:45
whitead
whitead reviewed Sep 13, 2024
View reviewed changes
tests/test_agents.py Outdated Show resolved Hide resolved
whitead
whitead approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - think you have a conflict with #389

paperqa/readers.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 13, 2024
@jamesbraza jamesbraza force-pushed the testing-ldp-more branch 2 times, most recently from 8736e3d to 05346be Compare September 13, 2024 06:23
@jamesbraza jamesbraza merged commit 870e2f6 into main Sep 13, 2024
5 checks passed
@jamesbraza jamesbraza deleted the testing-ldp-more branch September 13, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead