Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Pydantic validation in Python<3.12 #385

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

jamesbraza
Copy link
Collaborator

#322 dropped our min Python version from CI during debugging. This enabled a slight Pydantic incompatibility with Python<3.12 to slide under the radar in #383.

This PR:

  • Reintroduces min version testing to CI
  • Fixes the incompatibility

@jamesbraza jamesbraza added the bug Something isn't working label Sep 12, 2024
@jamesbraza jamesbraza self-assigned this Sep 12, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@jamesbraza jamesbraza merged commit 0a37ca8 into main Sep 12, 2024
5 checks passed
@jamesbraza jamesbraza deleted the fixing-311-pydantic-validation branch September 12, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants