Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating LitQAv2TaskDataset for agent training/evaluation #401

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Sep 13, 2024

This PR continues #386 to make a dataset:

  • Extends a GradablePaperQAEnvironment, that is able to give a meaningful reward
  • Creates a LitQATaskDataset base class for making one GradablePaperQAEnvironment/question in a LitQA-like dataset
    • Makes up a stub dataset StubLitQADataset in testing to confirm it works
  • Creates a LitQAv2TaskDataset for LitQA v2 from Hugging Face

@jamesbraza jamesbraza added the enhancement New feature or request label Sep 13, 2024
@jamesbraza jamesbraza self-assigned this Sep 13, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 13, 2024
paperqa/agents/task.py Outdated Show resolved Hide resolved
paperqa/agents/task.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sidnarayanan sidnarayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 13, 2024
@jamesbraza jamesbraza force-pushed the task-dataset branch 2 times, most recently from 7d66676 to efef0d4 Compare September 13, 2024 23:35
@jamesbraza
Copy link
Collaborator Author

The test failure is a flaky and unrelated test, merging

@jamesbraza jamesbraza merged commit 49273f2 into main Sep 14, 2024
3 of 5 checks passed
@jamesbraza jamesbraza deleted the task-dataset branch September 14, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants