Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken title search ut #411

Merged
merged 15 commits into from
Sep 16, 2024
Merged

Broken title search ut #411

merged 15 commits into from
Sep 16, 2024

Commits on Sep 14, 2024

  1. Changes assertion citations to match output, testing CI

    @nadolskit
    nadolskit committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    0db661c View commit details
    Browse the repository at this point in the history

  2. Ignore specific citation count in UT, build helper function for other… 

    … UTs
    @nadolskit
    nadolskit committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    092e7c4 View commit details
    Browse the repository at this point in the history

  3. Small grammar adjustment

    @nadolskit
    nadolskit committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    013afde View commit details
    Browse the repository at this point in the history

  4. change implementation, update UTs, cleanup, lint

    @nadolskit
    nadolskit committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    669988b View commit details
    Browse the repository at this point in the history

  5. Simplify regex expression, simplify test, add clarifying comment

    @nadolskit
    nadolskit committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    533fe9a View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. remove regex solution, replaced with logic that handles undefined val… 

    …ues. Pull main.
    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    145af72 View commit details
    Browse the repository at this point in the history

  2. remove vestigial print statemen

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5ff4022 View commit details
    Browse the repository at this point in the history

  3. lint

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c23161e View commit details
    Browse the repository at this point in the history

  4. correctly disable rule

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    88671f7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into broken-title-search-UT

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dae344e View commit details
    Browse the repository at this point in the history

  6. Add clarifying comment

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5f86258 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into broken-title-search-UT

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a66b68f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of https://github.com/Future-House/paper-qa into … 

    …broken-title-search-UT
    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6aca298 View commit details
    Browse the repository at this point in the history

  9. main version of journalquality

    @nadolskit
    nadolskit committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5d8e38c View commit details
    Browse the repository at this point in the history

  10. Update paperqa/types.py 

    Co-authored-by: James Braza <[email protected]>
    @nadolskit @jamesbraza
    nadolskit and jamesbraza committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    281a849 View commit details
    Browse the repository at this point in the history