Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to expose agents.RichHandler #489

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Refactor to expose agents.RichHandler #489

merged 4 commits into from
Sep 27, 2024
+55 −46

Conversation

jamesbraza
Copy link
Collaborator

  • Refactors out LOG_VERBOSITY_MAP for easier to read code
  • Decomposes is_running_under_cli and set_up_rich_handler utilities

@jamesbraza jamesbraza added the enhancement New feature or request label Sep 26, 2024
@jamesbraza jamesbraza self-assigned this Sep 26, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 26, 2024
whitead
whitead approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix bug from comment, but other wise LGTM

paperqa/agents/__init__.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@jamesbraza jamesbraza merged commit 8d84f92 into main Sep 27, 2024
4 of 5 checks passed
@jamesbraza jamesbraza deleted the exposing-rich-handler branch September 27, 2024 06:06
@jamesbraza jamesbraza mentioned this pull request Sep 28, 2024
Merged
jamesbraza added a commit that referenced this pull request Sep 28, 2024
@jamesbraza
Cleaning up #489's implementation (#503)
e6ab66f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@sidnarayanan sidnarayanan Awaiting requested review from sidnarayanan

@mskarlin mskarlin Awaiting requested review from mskarlin

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead