Broken reader ut #497
Merged
Broken reader ut #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
jamesbraza
reviewed
Sep 27, 2024
tests/test_paperqa.py
Outdated
| @@ -814,6 +814,10 @@ def test_pdf_reader_w_no_match_doc_details(stub_data_dir: Path) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| # default: ['method', 'scheme', 'host', 'port', 'path', 'query'] | |||
| # this is the default list + body | |||
| # this ensures vcr distinguishes requests with a different body | |||
There was a problem hiding this comment.
I am tripping up on "distinguishes". Do you mean this cassette will:
- Generate a new one if the body changes
- Not generate a new one if the body changes
There was a problem hiding this comment.
Maybe I can word this better, vcr uses these properties to distinguish how requests are different.
If you look through the cassette, many of the stored requests are identical with the exception of the body (identical method, URI, headers, etc)
for example the calls to https://api.openai.com/v1/embeddings and /v1/chat/completion.
Adding body won't create new cassettes; it just helps vcr correctly match the right request with its response.
jamesbraza
reviewed
Sep 27, 2024
tests/test_paperqa.py
Outdated
Comment on lines
817
to
820
| # vcr.VCR default: ('method', 'scheme', 'host', 'port', 'path', 'query') | ||
| # this is the default list + body | ||
| # Adding body won't create new cassettes; it just helps vcr correctly match the right request with its response. | ||
| @pytest.mark.vcr(match_on=["method", "scheme", "host", "port", "path", "query", "body"]) |
There was a problem hiding this comment.
Suggested change
| # vcr.VCR default: ('method', 'scheme', 'host', 'port', 'path', 'query') | |
| # this is the default list + body | |
| # Adding body won't create new cassettes; it just helps vcr correctly match the right request with its response. | |
| @pytest.mark.vcr(match_on=["method", "scheme", "host", "port", "path", "query", "body"]) | |
| # SEE: https://github.com/kevin1024/vcrpy/blob/v6.0.1/vcr/config.py#L43 | |
| VCR_DEFAULT_MATCH_ON = 'method', 'scheme', 'host', 'port', 'path', 'query' | |
| # Adding body won't create new cassettes; it just helps vcr correctly match the right request with its response. | |
| @pytest.mark.vcr(match_on=[*VCR_DEFAULT_MATCH_ON, "body"]) |
And if you could expand your comment to say why we need body here
dosubot
bot
added
size:S
jamesbraza
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems consistent now