Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed gen_answer's dead argument question #689

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

jamesbraza
Copy link
Collaborator

The gen_answer tool has an unused question arg. This PR removes it.


I observed for the LitQA2 question:

The gene EEF2 has introns 1 and 2, do they splice in a specific order?

The agent called gen_answer with the question arg:

Does the gene EEF2 splice intron 1 and 2 in a specific order?

Whereas this is mostly the same question, it has a few problems:

  • The innards of gen_answer use state.session.question, not the input question, so the logs were inaccurate
  • Perhaps the agent could cycle gen_answer with different input questions, when actually nothing different happens
  • It not ideal to have learned agents learning this argument, when it's actually dead code
    • This also wastes both prompt and completion tokens

@jamesbraza jamesbraza added the bug Something isn't working label Nov 15, 2024
@jamesbraza jamesbraza self-assigned this Nov 15, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@jamesbraza jamesbraza force-pushed the no-answer-gen-answer branch 2 times, most recently from af9bd65 to 38a6ce2 Compare November 15, 2024 18:59
@jamesbraza jamesbraza merged commit 4e1937d into main Nov 15, 2024
5 checks passed
@jamesbraza jamesbraza deleted the no-answer-gen-answer branch November 15, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants