Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usage of node12 which is deprecated in CI #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: usage of node12 which is deprecated in CI #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
# Actions-rs/install is unmaintained but works for now.
# Alternatives for when it breaks:
# - dtolnay/install - not a full replacement - only supports crates he uses (not audit currently)
# - baptiste0928/cargo-install - looks like it just compiles the crate and then caches it for subsequent runs
# - just `cargo install` and caching it
- uses: actions-rs/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to remove installation of cargo-audit entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be unnecessary. Maybe the GitHub runners come with it?

with:
crate: cargo-audit
version: latest
- run: cargo audit --version
# RUSTSEC-2020-0097: xcb - Soundness issue with base::Error
# RUSTSEC-2022-0048: xml-rs is Unmaintained
Expand Down