Add model precision to automatically generated submission readme #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunsuresh
requested changes
Aug 28, 2024
| @@ -133,7 +133,7 @@ def get_accuracy_metric(config, model, path): | |||
|
|
|||
| return is_valid, acc_results, acc_targets, acc_limits | |||
|
|
|||
| def get_result_string(version, model, scenario, result_path, has_power, sub_res, division="open", system_json=None): | |||
| def get_result_string(version, model, scenario, result_path, has_power, sub_res, model_precision, division="open", system_json=None): | |||
There was a problem hiding this comment.
We need to make sure this function is updated everywhere it is called from or make model_precision the last default argument.
There was a problem hiding this comment.
Matching the substring mlperf_utils.get_result_string or get_result_string through find, I'm getting only one occurance of the string which is in generate-mlperf-inference-submission/customize.py
There was a problem hiding this comment.
made changes in commit d0194dd
arjunsuresh
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: mlcommons#173
generated submission readme with updation: https://github.com/anandhu-eng/mlperf_inference_test_submissions_v4.1/tree/main/open/MLCommons/measurements/intel_spr_i9-reference-gpu-deepsparse_v1.8.0-default_config/mobilebert-base_quant-none-bert-99/offline