feat(fb): add dry_run mode to submission endpoint - #118
Merged
Conversation
Allow POST /submissions/?dry_run=true to validate the payload without persisting to MongoDB. This prevents false data accumulation from health-check cron jobs. Made-with: Cursor
muratmuzaffer
requested review from
DogukanUrker and
seberatolmez
as code owners
April 1, 2026 23:18
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
seberatolmez
approved these changes
Apr 2, 2026
seberatolmez
left a comment
seberatolmez
left a comment
Member
There was a problem hiding this comment.
lgtm @muratmuzaffer , we can merge after @DogukanUrker' s approval
DogukanUrker
approved these changes
Apr 3, 2026
Member
|
really good job @muratmuzaffer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
dry_runquery parameter toPOST /submissions/. Whendry_run=true, the endpoint fully validates the incoming payload (form existence, active status, dates, required fields) but skips the MongoDBinsert_oneandsubmission_countincrement. This allows health-check cron jobs to verify the endpoint without polluting the database.Related Issue
Closes #116
Checklist