feat(fb): implement submission CRUD service - #64
Merged
Conversation
DogukanUrker
requested changes
Jan 20, 2026
DogukanUrker
left a comment
Member
There was a problem hiding this comment.
WAY better than the prev. PR - just have a few things to consider. than we good to go. good job!!
- Add ObjectId.is_valid() validation in _to_object_id - Restore .env.example file
Contributor
Author
|
.env.example deletion Regarding ObjectId.is_valid() validation |
DogukanUrker
self-requested a review
January 21, 2026 08:51
DogukanUrker
approved these changes
Jan 21, 2026
DogukanUrker
left a comment
Member
There was a problem hiding this comment.
looks good now, you can merge it whenever
Contributor
Author
|
Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the submission service layer for managing form submissions as specified in issue #48.
Added
SubmissionServiceclass inservices/form/app/services/submission_service.pycreate_submission()- Creates submission with form validationget_submission_by_id()- Retrieves submission by IDget_submissions_by_form_id()- Paginated submission list (default: 10, max: 100)start_date)deadline)submission_countincrement on formapp/services/__init__.pyTechnical Details
async/awaitpatternawait cursor.to_list(length=limit)for paginationValueErrorfor business logic errorsPyMongoErrorfor database errorsRelated Issue
Closes #48
Checklist