Fix maskable icon #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the application's icon configuration to properly support maskable icons in the PWA manifest. The key changes correct the purpose designation of existing icons and add dedicated maskable icon assets to ensure proper display across different platforms and contexts.
Key Changes:
- Changed existing WebP icons from
maskabletoanypurpose to reflect their actual design - Added dedicated maskable icon files (
/maskable-icon.pngand/maskable-icon.webp) with propermaskablepurpose - Added Apple touch icon to the manifest for improved iOS support
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/app/manifest.ts | Updated icon purposes from maskable to any for existing icons and added new manifest entries for dedicated maskable icons and Apple touch icon |
| app/public/service-worker.js | Added new maskable icon files to the service worker's core assets cache list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24
This pull request updates the application's icon assets and manifest to improve support for maskable icons and enhance compatibility with various devices. The changes add new maskable icon files and adjust the manifest configuration to ensure proper icon usage for different contexts.
Asset additions:
/maskable-icon.pngand/maskable-icon.webpto the core assets for service worker caching.Manifest improvements:
purposeof existing WebP icons (/icons/icon-192x192.webpand/icons/icon-512x512.webp) frommaskabletoanyto clarify their intended usage. [1] [2]/apple-touch-icon.webpto the manifest for improved support on Apple devices./maskable-icon.webpand/maskable-icon.pngwithpurpose: 'maskable'for better PWA maskable icon support.