Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 쿠키 도메인 변경 #927

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Conversation

Sangwook02
Copy link
Member

@Sangwook02 Sangwook02 commented Feb 23, 2025

🌱 관련 이슈

📌 작업 내용 및 특이사항

📝 참고사항

📚 기타

Summary by CodeRabbit

  • Chores
    • URL 구성을 위해 사용되는 기본 도메인 이름을 이전 버전에서 새로운 도메인으로 업데이트하였습니다.

@Sangwook02 Sangwook02 self-assigned this Feb 23, 2025
@Sangwook02 Sangwook02 requested a review from a team as a code owner February 23, 2025 11:20
Copy link

coderabbitai bot commented Feb 23, 2025

📝 Walkthrough

Walkthrough

이 PR은 UrlConstant 클래스 내의 ROOT_DOMAIN 상수 값을 "gdschongik.com"에서 "wawoo.dev"로 변경합니다. 해당 상수는 애플리케이션 전반의 URL 생성과 도메인 관련 로직에서 사용됩니다.

Changes

파일 변경 요약
src/.../UrlConstant.java ROOT_DOMAIN 상수 값 변경 (gdschongik.comwawoo.dev)

Possibly related PRs

Poem

귀여운 토끼가 노래합니다,
"wawoo.dev" 빛나는 새 출발!
코드 숲 속을 깡충깡충 뛰며,
도메인 변화 축하하는 리듬 속에,
개발의 길 함께 달려가자 🐇!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38004fe and 377a084.

📒 Files selected for processing (1)
  • src/main/java/com/gdschongik/gdsc/global/common/constant/UrlConstant.java (1 hunks)
🔇 Additional comments (1)
src/main/java/com/gdschongik/gdsc/global/common/constant/UrlConstant.java (1)

56-56:

❓ Verification inconclusive

도메인 변경 영향 확인 필요

도메인 변경이 쿠키 및 관련 기능에 미치는 영향을 확인해주세요:

  1. 쿠키 도메인 설정이 올바르게 적용되는지
  2. 클라이언트 리다이렉션이 새로운 도메인으로 정상 작동하는지
  3. CORS 설정이 새로운 도메인에 맞게 업데이트되었는지

다음 스크립트를 실행하여 도메인 관련 설정을 확인해주세요:


🏁 Script executed:

#!/bin/bash
# Description: 도메인 관련 설정 확인

# 쿠키 도메인 설정 확인
echo "쿠키 도메인 설정 확인:"
rg -l "setCookie|cookie.setDomain|.domain" --type java

# CORS 설정 확인
echo "\nCORS 설정 확인:"
rg -l "cors|allowedOrigins|@CrossOrigin" --type java

# 리다이렉션 URL 확인
echo "\n리다이렉션 URL 확인:"
rg -l "redirect|sendRedirect|setHeader.*Location" --type java

Length of output: 31254


도메인 변경 영향 확인 결과

현재 변경된 ROOT_DOMAIN 값("wawoo.dev")이 쿠키 설정, CORS 정책, 리다이렉션 URL 등 여러 곳에서 사용되고 있음을 확인했습니다. 특히 아래 사항을 점검해 주세요:

  • 쿠키 도메인 설정:

    • 다수의 컨트롤러와 서비스(AuthController.java, CommonMemberController.java 등)에서 쿠키 도메인 관련 코드가 사용되고 있으므로, 변경된 도메인이 올바르게 반영되고 있는지 테스트해 주세요.
  • CORS 설정:

    • src/main/java/com/gdschongik/gdsc/global/config/WebSecurityConfig.java에서 CORS 관련 설정이 관리되고 있으니, 새로운 도메인에 맞게 올바르게 구성되었는지 확인해 주세요.
  • 리다이렉션 URL:

    • src/main/java/com/gdschongik/gdsc/global/common/constant/SecurityConstant.javasrc/main/java/com/gdschongik/gdsc/global/security/CustomOAuth2AuthorizationRequestResolver.java에 적용된 리다이렉션 관련 로직이 새로운 도메인에 적합하게 처리되는지 점검해 주세요.

위 사항들에 대해 실제 동작 테스트 및 추가 검토를 진행해 주시기 바랍니다.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@kckc0608 kckc0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 Build Scan published

@Sangwook02 Sangwook02 merged commit e393020 into develop Feb 23, 2025
1 of 2 checks passed
@Sangwook02 Sangwook02 deleted the chore/926-cookie-domain branch February 23, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚙️ 쿠키 도메인 변경
2 participants