refactor: 중복 로직 삼항연산자로 개선

GDSC-Hongik · Aug 29, 2024 · 2f0aede · 2f0aede
1 parent a2195bc
commit 2f0aede
Showing 1 changed file with 10 additions and 14 deletions.
diff --git a/apps/admin/app/studies/assignments/[studyDetailId]/_components/AssignmentHeader.tsx b/apps/admin/app/studies/assignments/[studyDetailId]/_components/AssignmentHeader.tsx
@@ -29,26 +29,22 @@ const AssignmentHeader = ({ assignment, disabled }: AssignmentHeaderProps) => {
   const onOpen = methods.getValues("onOpen");
 
   const handleClickSubmit = async () => {
+    if (assignmentStatus === "CANCELLED") return;
+
     const data = {
       title: methods.getValues("title"),
       descriptionNotionLink: methods.getValues("descriptionNotionLink"),
       deadLine: methods.getValues("deadLine"),
     };
 
-    if (assignmentStatus === "NONE") {
-      const { success } = await studyApi.createAssignment(studyDetailId, data);
-      if (success) {
-        revalidateTagByName(`${tags.assignments} ${studyDetailId.toString()}`);
-        revalidateTagByName(tags.assignments);
-        onOpen();
-      }
-    } else if (assignmentStatus === "OPEN") {
-      const { success } = await studyApi.patchAssignment(studyDetailId, data);
-      if (success) {
-        revalidateTagByName(`${tags.assignments} ${studyDetailId.toString()}`);
-        revalidateTagByName(tags.assignments);
-        onOpen();
-      }
+    const { success } =
+      assignmentStatus === "NONE"
+        ? await studyApi.createAssignment(studyDetailId, data)
+        : await studyApi.patchAssignment(studyDetailId, data);
+    if (success) {
+      revalidateTagByName(`${tags.assignments} ${studyDetailId.toString()}`);
+      revalidateTagByName(tags.assignments);
+      onOpen();
     }
   };