Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS-128 [!HOTFIX] 공공데이터 에러 핸들링 #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions backend/util/OpenAPI.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ function insertGrain(url, queryParams) {
async function (error, response, body) {
var data;
// 에러는 xml 또는 json으로 오고 statusCode로는 잡을 수 없음
if (body[0] == '<') {
if (body == undefined) {
console.log(body);
return reject();
}
else if (body[0] == '<') {
console.log(body);
return reject();
}
Expand Down Expand Up @@ -86,7 +90,11 @@ function insertPermission(url, queryParams) {
function (error, response, body) {
var data;
// 에러는 xml 또는 json으로 오고 statusCode로는 잡을 수 없음
if (body[0] == '<') {
if (body == undefined) {
console.log(body);
return reject();
}
else if (body[0] == '<') {
console.log(body);
return reject();
}
Expand All @@ -100,7 +108,7 @@ function insertPermission(url, queryParams) {

// 정상 response
for (var i = 0; i < data.length; ++i) {
(async() => {
(async () => {
await prisma.permission.create({
data: {
itemSeq: data[i].ITEM_SEQ,
Expand Down Expand Up @@ -154,7 +162,11 @@ function insertHousehold(url, queryParams) {
async function (error, response, body) {
var data;
// 에러는 xml 또는 json으로 오고 statusCode로는 잡을 수 없음
if (body[0] == '<') {
if (body == undefined) {
console.log(body);
return reject();
}
else if (body[0] == '<') {
console.log(body);
return reject();
}
Expand Down Expand Up @@ -202,7 +214,7 @@ function grainDB() {

for (var pageNo = 1; pageNo <= loopCount; ++pageNo) {
var queryParams = "?" + encodeURIComponent("serviceKey") + "=" + process.env.SERVICE_KEY;
queryParams += "&" + encodeURIComponent("numOfRows") + "=" + encodeURIComponent(pageNo == loopCount? endRows: numOfRows);
queryParams += "&" + encodeURIComponent("numOfRows") + "=" + encodeURIComponent(pageNo == loopCount ? endRows : numOfRows);
queryParams += "&" + encodeURIComponent("pageNo") + "=" + encodeURIComponent(pageNo);
queryParams += "&" + encodeURIComponent("type") + "=" + encodeURIComponent("json");

Expand Down Expand Up @@ -241,10 +253,10 @@ function permissionDB() {

for (var pageNo = 1; pageNo <= loopCount; ++pageNo) {
var queryParams = "?" + encodeURIComponent("serviceKey") + "=" + process.env.SERVICE_KEY;
queryParams += "&" + encodeURIComponent("numOfRows") + "=" + encodeURIComponent(pageNo == loopCount? endRows: numOfRows);
queryParams += "&" + encodeURIComponent("numOfRows") + "=" + encodeURIComponent(pageNo == loopCount ? endRows : numOfRows);
queryParams += "&" + encodeURIComponent("pageNo") + "=" + encodeURIComponent(pageNo);
queryParams += "&" + encodeURIComponent("type") + "=" + encodeURIComponent("json");

await insertPermission(url, queryParams).then(() => {
process.stdout.clearLine();
process.stdout.cursorTo(0);
Expand Down Expand Up @@ -280,7 +292,7 @@ function householdDB() {

for (var pageNo = 1; pageNo <= loopCount; ++pageNo) {
var queryParams = "?" + encodeURIComponent("serviceKey") + "=" + process.env.SERVICE_KEY;
queryParams += "&" + encodeURIComponent("numOfRows") + "=" + encodeURIComponent(pageNo == loopCount? endRows: numOfRows);
queryParams += "&" + encodeURIComponent("numOfRows") + "=" + encodeURIComponent(pageNo == loopCount ? endRows : numOfRows);
queryParams += "&" + encodeURIComponent("pageNo") + "=" + encodeURIComponent(pageNo);
queryParams += "&" + encodeURIComponent("type") + "=" + encodeURIComponent("json");

Expand Down