Electron velocity distribution implementation#245
Electron velocity distribution implementation#245bear-is-asleep wants to merge 66 commits intoGENIE-MC:masterfrom
Conversation
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
I haven't look at the whole thing yet, but there are a number of things you can start fixing already.
|
|
||
| public : | ||
| virtual ~ElectronVelocity(); | ||
| ElectronVelocity(); |
There was a problem hiding this comment.
Remove completely the default constructor. You can flag it deleted
There was a problem hiding this comment.
I get an error if i remove the default constructor: Generator/lib/libGPhNuclSt.so: undefined symbol: _ZN5genie16ElectronVelocityC2Ev
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
ok, I think we have a good starting point, we just need to fix a few minor code issues and have a bit of thoughts about what we need to change in the framework.
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
You committed a root file! Remove it.
Other things needs to change too.
src/Physics/NuclearState/LinkDef.h
Outdated
| #pragma link C++ class genie::SecondNucleonEmissionI; | ||
| #pragma link C++ class genie::SpectralFunction2p2h; | ||
|
|
||
| //#pragma link C++ class genie::ElectronVelocity; |
There was a problem hiding this comment.
Remove instead of commenting out
…andomizer for bohr velocity
…into brindenc Updating my branch with nu e updates
…rection randomizer for bohr model
Fixed direction generator
Mroda/ev map
…rface Revert "Feature/target interface"
…c parameters for the PXSec integrators in NuElectron.
|
This is a proof of concept that used an undesirable new interface for Target. The new PR is #331 |
2 participants
Genie currently implements a static velocity for electrons bound to the nucleus in all interactions involving bound electrons. These changes introduce a module to select an initial electron velocity from a distribution by loading a configuration submodule into the ElectronVelocity module in the nuclear state folder. Future velocity distributions can be implemented simply by creating a submodule that inherits from ElectronVelocity. This PR also introduces changes to the framework which allows for setting the initial state electron 4 momentum and boosting into its rest frame.