Implementation of 1p1h and npnh Martini et al channels#472
Open
lavinia-russo wants to merge 23 commits intoGENIE-MC:masterfrom
Open
Implementation of 1p1h and npnh Martini et al channels#472lavinia-russo wants to merge 23 commits intoGENIE-MC:masterfrom
lavinia-russo wants to merge 23 commits intoGENIE-MC:masterfrom
Conversation
… 2p2h - 3p3h separation yet. No A-scaling
…e consistent with what is implemented, error came from susa tables)
…ectory in the config file (see readme), deleted some comments, removed martini2016
…/Multinucleon/XSection/MartiniEricsonChanfrayMarteauMECPXSec2024.cxx src/Physics/QuasiElastic/XSection/MartiniQELPXSec.cxx
Sync martini2p2h with upstream master before pull request.
nusense
reviewed
Jan 24, 2026
Member
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
Overall very clean written and organized code. I picked a few nits but generally I have little issue with what's there.
src/Physics/Multinucleon/XSection/MartiniEricsonChanfrayMarteauMECPXSec2024.cxx
Show resolved
Hide resolved
Member
|
Adding link to the DocDB presentation for the GENIE core meeting talk from last June: https://genie-docdb.pp.rl.ac.uk/cgi-bin/private/ShowDocument?docid=535. |
nusense
previously approved these changes
Feb 26, 2026
Member
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
Essentially all my queries/suggestions have been resolved, so I'll approve, but not merge, this.
Member
|
Sorry the correct user is not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fork implements the 1p1h and npnh channels of the Martini et al. model.
The chosen tune is G24_12a. All details can be found in the PRD article (DOI: 10.1103/v8hq-kppp).
A presentation of this implementation was given at the GENIE Core Meeting on Monday, June 16th.
As requested during the meeting, the old non-working npnh implementation from 2016 has been removed.