adding new Reweight calculator for new hA2025 FSI model #42
adding new Reweight calculator for new hA2025 FSI model #42M7medS3d wants to merge 11 commits intoGENIE-MC:masterfrom
Conversation
M7medS3d
changed the title
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
This isn't a full review, but a few concerns that come up upon a semi-cursory look
| AlgFactory* algf = AlgFactory::Instance(); | ||
|
|
||
| Algorithm* alg = algf->AdoptAlgorithm( id ); | ||
| fFSIModel = dynamic_cast< HAIntranuke2018* >( alg ); |
There was a problem hiding this comment.
I want to understand what the intent of this code is. Is it to take HAIntranuke2018 to HAIntranuke2025? Is there code to check that the input was generated with HAIntranuke2018?
There was a problem hiding this comment.
yes, given the FSI issue observed in hA2018, we want to Reweight from hA2018 to hA2025, the above code I think just check if the sample was generated with hA2018.
There was a problem hiding this comment.
This code assures us that the requested algorithm is HAIntranuke2018 via the dynamic_cast. But my question was more directed at whether there is (or possibly could be) some check that the data one is reweighting was actually generated with HA2018. That is is there any check to prevent, say, reweighting data that was generated with 2025, but treated as if it were 2018, with the weights 2018->2025? That might not be possible, and it might just come down to vigilance on the part of the user.
src/RwCalculators/GReWeighthA2025.h
Outdated
| Physics changes are considered separately for pions and nucleons. | ||
| Unitarity is explicitly conserved. | ||
|
|
||
| \author Jim Dobson <J.Dobson07 \at imperial.ac.uk> |
There was a problem hiding this comment.
Again, a review of the author list.
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
I'm going to approve this, though I have one outstanding question.
| AlgFactory* algf = AlgFactory::Instance(); | ||
|
|
||
| Algorithm* alg = algf->AdoptAlgorithm( id ); | ||
| fFSIModel = dynamic_cast< HAIntranuke2018* >( alg ); |
There was a problem hiding this comment.
This code assures us that the requested algorithm is HAIntranuke2018 via the dynamic_cast. But my question was more directed at whether there is (or possibly could be) some check that the data one is reweighting was actually generated with HA2018. That is is there any check to prevent, say, reweighting data that was generated with 2025, but treated as if it were 2018, with the weights 2018->2025? That might not be possible, and it might just come down to vigilance on the part of the user.
|
Thanks a lot Robert for approving that. Regarding your last comment, this is a good question that I think don't have good way to go around. If you have any ideas please let me know. |
3 participants
added a new reweigh function for the new hA2025 FSI model.