Add in Systematic Weights Associated with the Kinematics of Hadron FSI#45
Add in Systematic Weights Associated with the Kinematics of Hadron FSI#45sjgardiner wants to merge 10 commits intoGENIE-MC:masterfrom
Conversation
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
A couple of comments generated last week but never submitted.
| return false; | ||
| default: | ||
| return true; | ||
| } |
There was a problem hiding this comment.
I think the list of scattering types this can't be applied to needs to be reviewed. For instance, surely it can't be applied to kScInverseMuDecay and kScIMDAnnihilation but they're not in the list. A careful scrutiny would be wise.
| << " with PDG code = " << pdgc | ||
| << " and FSI code = " << fsi_code | ||
| << " (" << INukeHadroFates::AsString((INukeFateHA_t)fsi_code) << ")\n"; | ||
|
|
There was a problem hiding this comment.
Here's where we get into trouble with multiple versions of the INukeFate enum list. Was the fsi_code set with INukeHadroFates or INukeHadroFates2018 (or possibly the soon to be included 2025)?
I'm told the intent is the include the 2018 set, but at a first look it's very unclear how any fates include file is pulled in.
| // std::cerr << "TLab: " << tlab_v << " costhcm: " << costhcm_v << " np/pp " << np_pp << " weight: " << weight << std::endl; | ||
|
|
||
| event_weight *= weight; | ||
| } |
There was a problem hiding this comment.
This fetching the weight and doing event_weight *= weight is a bit unwieldy given that event_weight is always going to still be 1 from the point that the variable was declared and initialized. Why introduce yet another variable? Same in the next block of code.
| TFile * fTestFile; | ||
| TNtuple * fTestNtp; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
These are #ifdef out, but there no corresponding mention in the .cxx. I'd suggest removing this vestigial bit if it's not going to be useful in the future.
|
|
||
| double E = (f1 + f2 + f3).M(); | ||
| if (fFixPiPro && fBiasPiPro != 0.) { | ||
| // Momentum transfer from parent to child nulceon |
There was a problem hiding this comment.
nulceon to nucleon (lines 183 & 194)
3 participants
Adds in uncertainties on p-n, p-p, and n-n angular cross sections, as implemented by a bootstrapped evaluation of the uncertainties in the offsets between the SAID model and its constituent datasets. These form an uncertainty on inelastic and charge-exchange interactions in hadron FSI.
Also adds in an uncertainty on the amount of bias (B) in hadron FSI production. The size of the uncertainty is the difference in the bias in GENIE FSI (B=0, uniform kinematics), and the INCL bias.
This PR combines and supersedes Reweight #37 and GENIE-MC/Generator#449 originally submitted by @gputnam.