Skip to content

Update the reweight tool for z expension model#48

Open
LiangLiu212 wants to merge 2 commits intoGENIE-MC:masterfrom
LiangLiu212:feature/uncertainty-zexp
Open

Update the reweight tool for z expension model#48
LiangLiu212 wants to merge 2 commits intoGENIE-MC:masterfrom
LiangLiu212:feature/uncertainty-zexp

Conversation

@LiangLiu212
Copy link
Contributor

  • Add reweighting support for the z-expansion axial form factor.

  • Update the reweighting implementation for the z-expansion vector form factor.

Weights are computed by scaling the cross section using standard error propagation.

  • Disable the single-parameter dial tweak mode, in this ways, not support for varying parameters according to Cholesky decomposition to get the standard deviation. I don't this it is useful for error estimation. But I can re-implement it if we need this.

- add the reweight for z expension axial form factor
- update the reweight for z expension vector form factor

Using the error propagation formula to scale the cross-section to get
the weight.
Copy link
Member

@nusense nusense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the question about using kXSecTwkDial_ZExpELFF where I'd expect kXSecTwkDial_ZExpZAFF.

I also checked with Jeremy Wolcott to see whether NOvA is using the individual ZExpELFF tweak parameters. We agreed that these seem to be vector form factor parameters and NOvA doesn't use those, only the axial, so I don't think we're pulling the rug out from under them.


\created March 25, 2024

\cpright Copyright (c) 2003-2025, The GENIE Collaboration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well claim the copyright through the year it's getting committed: 2026. Here and elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will bump copyright.

@LiangLiu212
Copy link
Contributor Author

Can you check the question about using kXSecTwkDial_ZExpELFF where I'd expect kXSecTwkDial_ZExpZAFF.

I also checked with Jeremy Wolcott to see whether NOvA is using the individual ZExpELFF tweak parameters. We agreed that these seem to be vector form factor parameters and NOvA doesn't use those, only the axial, so I don't think we're pulling the rug out from under them.

As I understand, the previous implementation of reweight of axial form factor can only include the correlation matrix by using grwghtnp and we need to feed covariance matrix when we run the reweight.

However, I think we should consider the uncertainties of the ZExp model as a whole, rather than focusing on the individual parameters. And we don't need to have a feature to tweak individual parameter.

So, in my PR, I provide a new method to estimate the uncertainties of ZExp model with covariance matrix by using the error propagation method.

@LiangLiu212
Copy link
Contributor Author

I just realized that we might still want to reweight the Z-expansion from one set of parameters to another.
However, I think this should be treated as a separate feature rather than part of the uncertainty estimation. I will think about how to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants