Skip to content

Publish to pypi #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofekby merged 7 commits into from
Dec 2, 2025
Merged

Publish to pypi #2

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
564b837
bla
ofekby Nov 27, 2025
b8b1d44
Re-enable publish-release job in CI workflow
ofekby Nov 27, 2025
df75da2
Fix formatting in README for Local Installation section
ofekby Nov 27, 2025
8c5d404
Enable publishing to PyPI in CI workflow
ofekby Dec 2, 2025
40b73f9
Bump version to 0.5.0 in pyproject.toml and uv.lock - first publish
ofekby Dec 2, 2025
9bb4c44
Add environment specification for PyPI production in publish-release job
ofekby Dec 2, 2025
7226222
Merge remote-tracking branch 'origin/main' into publish-to-pypi
ofekby Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ jobs:
publish-release:
needs: build-release
runs-on: ubuntu-latest
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish-release job will execute on every successful build, including pull requests, because it only depends on build-release without explicitly checking the trigger conditions. Although build-release depends on tag-release which has a condition for main branch, the dependency chain alone doesn't prevent the job from being triggered in other contexts.

Consider adding an explicit condition to ensure it only runs when intended:

publish-release:
  needs: build-release
  runs-on: ubuntu-latest
  if: needs.tag-release.outputs.tag_created == 'true'
  environment: pypi-production

This makes the intent clear and adds an extra safety layer to prevent accidental publishes.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
if: needs.tag-release.outputs.tag_created == 'true'

Copilot uses AI. Check for mistakes.
environment: pypi-production
permissions:
id-token: write # Required for trusted publishing
steps:
Expand Down