Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new field specification application prior to SolverBase::solverStep in SolverBase::execute #3394

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Oct 11, 2024

This PR adds the application of PhysicsSolver specific FieldSpecification prior to the solverStep

  • add new FieldSpecification prior to the start of the SolverBase::solverStep
  • Deprecate isInitialCondition flag and replace with a list of initial conditions....somewhere to be determined. The list can be filled by the isInitialCondition flag for now, prior to its removal.

@rrsettgast rrsettgast self-assigned this Oct 11, 2024
Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of specifying the list of names can't we have the solver apply all field specifications on certain fields like we do for boundary conditions?

@rrsettgast
Copy link
Member Author

instead of specifying the list of names can't we have the solver apply all field specifications on certain fields like we do for boundary conditions?

No. Then we can't target specifications for the solver. We should actually go the other way and have specific lists of BC's to be applied by the physics packages. For example, if we have a displacement field specificaiton, the solid mechanics solver will always apply it. So we should list Dirichlet, Neumann, etc bc's to apply. So we can think of it as the physics package can specify what FieldSpecification objects to apply as a BC.

The application in this PR is simply "overwrite data before the step begins"

@rrsettgast rrsettgast marked this pull request as ready for review October 30, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants