Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove rel perm from wells #3483

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

refactor: remove rel perm from wells #3483

wants to merge 24 commits into from

Conversation

paveltomin
Copy link
Contributor

not used anyway

@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 6, 2024
@paveltomin paveltomin self-assigned this Dec 6, 2024
@paveltomin paveltomin removed the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 9, 2024
Base automatically changed from pt/comp-flow-tests to develop December 15, 2024 23:43
@paveltomin paveltomin removed the request for review from cssherman December 16, 2024 19:49
@paveltomin
Copy link
Contributor Author

@tjb-ltk @dkachuma are you ok with the change?

dkachuma
dkachuma reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@dkachuma dkachuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used but the code was supposedly forward looking. We might need this in the well later. I'll let @tjb-ltk confirm.

@tjb-ltk
Copy link
Contributor

tjb-ltk commented Jan 14, 2025 •
edited
Loading

Forward looking for sure... access to the relperm and pvt models would be needed for something like pseudo pressure modeling for condensate dropout, an alternative to fine grids around wells.. but even in this workflow a well estimator is needed, which then requires further development of the parallel framework. I would confer with the GEOS executive committee about their short/med/long term strategic objectives and plans.

tjb-ltk
tjb-ltk approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@tjb-ltk tjb-ltk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until a use case comes along its probably better to remove these fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkachuma dkachuma dkachuma left review comments

@tjb-ltk tjb-ltk tjb-ltk approved these changes

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@ryar9534 ryar9534 Awaiting requested review from ryar9534 ryar9534 is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@paveltomin paveltomin

Labels
flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveltomin @tjb-ltk @dkachuma