fix: issue 3499 #3500
Merged
fix: issue 3499 #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
reviewed
Dec 31, 2024
| @@ -250,7 +250,8 @@ void JFunctionCapillaryPressure::saveConvergedRockState( arrayView2d< real64 con | |||
| { | |||
| permeability = convergedPermeability[ei][0][2]; | |||
| } | |||
| GEOS_ERROR_IF( permeability < LvArray::NumericLimits< real64 >::epsilon, "Zero permeability in J-function capillary pressure" ); | |||
| // 9.869233×10−13 is Darcy to sq m factor | |||
| GEOS_ERROR_IF( permeability < LvArray::NumericLimits< real64 >::epsilon * 9.869233e-13, "Zero permeability in J-function capillary pressure" ); | |||
There was a problem hiding this comment.
why is this error check even necessary? A zero permeability is a valid number and all underflows are flushed to zero.
There was a problem hiding this comment.
there is a division down here
dkachuma
approved these changes
Jan 13, 2025
src/coreComponents/constitutive/capillaryPressure/JFunctionCapillaryPressure.cpp
Outdated
Show resolved
Hide resolved
added 2 commits
January 13, 2025 17:16
paveltomin
requested review from
rrsettgast,
MelReyCG,
corbett5 and
wrtobin
as code owners
paveltomin
added
ci: run CUDA builds
CusiniM
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3500 +/- ##
===========================================
- Coverage 56.53% 56.52% -0.01%
===========================================
Files 1157 1157
Lines 100617 100617
===========================================
- Hits 56880 56878 -2
- Misses 43737 43739 +2 ☔ View full report in Codecov by Sentry. |
paveltomin
removed
ci: run CUDA builds
MelReyCG
approved these changes
Feb 4, 2025
Comment on lines
+33
to
+34
| /// Darcy to m^2 conversion factor | ||
| static constexpr double DarcyToSqM = 9.869233e-13; |
There was a problem hiding this comment.
The PR looks good to me. Just a small thing, you could move this constant into PhysicsConstant.hpp if you think it fits better.
There was a problem hiding this comment.
The PR looks good to me. Just a small thing, you could move this constant into
PhysicsConstant.hppif you think it fits better.
thank
will keep it in units
paveltomin
added
ci: run CUDA builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #3499