feat: add analytical leakoff #3525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guotong-Ren
requested review from
rrsettgast,
CusiniM,
paveltomin,
castelletto1,
frankfeifan,
ryar9534 and
jhuang2601
as code owners
paveltomin
reviewed
Jan 28, 2025
| // mid-point rule in time | ||
| //localRhs[localRow] += m_leakoffConst * area[kfe] * dens[kfe][0] / sqrt(time + dt / 2.0 - m_fractureCreationTime[kfe]); | ||
| localRhs[localRow] += m_leakoffConst * area[kfe] * dens[kfe][0] / sqrt(time + dt / 2.0 - m_fractureCreationTime[kfe]); | ||
| std::cout << "creation time " << kfe << " " << m_fractureCreationTime[kfe] << std::endl; |
paveltomin
reviewed
Jan 28, 2025
| [&]( localIndex const, | ||
| FaceElementSubRegion const & subRegion ) | ||
| { | ||
| std::size_t regionSize = subRegion.size(); |
There was a problem hiding this comment.
replace size_t with localIndex
paveltomin
reviewed
Jan 28, 2025
| arrayView1d< integer const > const elemGhostRank = subRegion.ghostRank(); | ||
|
|
||
| const int numDof = 1; | ||
| const int numEqn = 1; |
paveltomin
reviewed
Jan 28, 2025
| forAll< serialPolicy >( regionSize, | ||
| [&] GEOS_HOST_DEVICE ( localIndex const kfe ) mutable | ||
| { | ||
| if ( elemGhostRank[kfe] >= 0 || time == m_fractureCreationTime[kfe] ) return; |
There was a problem hiding this comment.
<= for time comparison here? or some epsilon?
paveltomin
reviewed
Jan 28, 2025
| globalIndex dofIndices[numDof]{}; | ||
| real64 localJacobian[numEqn][numDof]{}; | ||
| forAll< serialPolicy >( regionSize, | ||
| [&] GEOS_HOST_DEVICE ( localIndex const kfe ) mutable |
There was a problem hiding this comment.
not sure if mutable is needed
There was a problem hiding this comment.
as a matter of fact, I don't think mutable device lambdas are supported
CusiniM
reviewed
Jan 28, 2025
| @@ -256,6 +264,11 @@ class HydrofractureSolver : public POROMECHANICS_SOLVER | |||
| // flag to determine whether or not to apply lagging update for the fracture stencil weights | |||
| integer m_isLaggingFractureStencilWeightsUpdate; | |||
|
|
|||
| // record to fracture cell creatition time | |||
| std::vector<double> m_fractureCreationTime; | |||
There was a problem hiding this comment.
Suggested change
| std::vector<double> m_fractureCreationTime; | |
| array1d<real64> m_fractureCreationTime; |
CusiniM
reviewed
Jan 28, 2025
| std::vector<double> m_fractureCreationTime; | ||
|
|
||
| // analytical leakoff coefficient | ||
| real64 m_leakoffConst; |
There was a problem hiding this comment.
Suggested change
| real64 m_leakoffConst; | |
| real64 m_leakoffCoefficient; |
?
CusiniM
reviewed
Jan 28, 2025
| @@ -179,6 +179,8 @@ class HydrofractureSolver : public POROMECHANICS_SOLVER | |||
|
|
|||
| constexpr static char const * isLaggingFractureStencilWeightsUpdateString() { return "isLaggingFractureStencilWeightsUpdate"; } | |||
|
|
|||
| constexpr static char const * leakoffConstString() {return "leakoffConst"; } | |||
There was a problem hiding this comment.
Suggested change
| constexpr static char const * leakoffConstString() {return "leakoffConst"; } | |
| constexpr static char const * leakoffCoefficientString() {return "leakoffCoefficient"; } |
?
CusiniM
reviewed
Jan 28, 2025
| const int localRow = presDofNumber[kfe] - rankOffset; | ||
| for( integer idof = 0; idof < numDof; ++idof ) | ||
| dofIndices[idof] = presDofNumber[kfe] + idof; | ||
| localJacobian[0][0] = m_leakoffConst * area[kfe] * dDens_dPressure[kfe][0] / sqrt(time + dt / 2.0 - m_fractureCreationTime[kfe]); |
CusiniM
reviewed
Jan 28, 2025
I am a numerical believer too. but when it shows strong transient effects, especially during the fracturing, enormous refinement near the fracture is seen to match the theoretical solution. That is why I think this feature can complement applications to some extent and also maintain a quite good level of preciseness. I will show our studies next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Carter's law to complement the fracture propagation in the elastic media.