Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix Thermal Stress Updates #3568

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

npillardou
Copy link

@npillardou npillardou commented Feb 25, 2025

This PR tries to correct the thermal stress calculations based on the difference from initialTemperature in the formula.
This way, thermal stress is ONLY introduced by a temperature change from the initial stage.

@jhuang2601 jhuang2601 changed the title Add Thermal Stress calculations fix feat: Fix Thermal Stress Updates Feb 27, 2025
@jhuang2601 jhuang2601 added type: feature New feature or request ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Feb 27, 2025
@paveltomin
Copy link
Contributor

Few relatively small comments:

  • probably no need to introduce smallStrainUpdateThermoPoromechanics and make it different from smallStrainUpdatePoromechanics, only one updated version should be enough to avoid confusion and potential inconsistencies
  • same for computeTotalStressWithInitialTemperature vs computeTotalStress

the rest seems fine to me, thanks for the efforts.

Between initialTemperature or referenceTemperature i prefer the second one, but that would require introducing it for coupled solid and making some logic around that, probably can be done later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants