Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add mathpresso to spack #3575

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Add mathpresso to spack #3575

wants to merge 2 commits into from

Conversation

bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Feb 27, 2025 •
edited
Loading

This PR:

  • Creates a spack variant and recipe for mathpresso.
  • Update spack-generated host-configs on LC to include mathpresso (only GEOS host-configs modified, LvArray dependencies unchanged)

Relates to GEOS-DEV/thirdPartyLibs#298

@bmhan12 bmhan12 added type: build system Build system issue type: CI Concerns github workflows or generic CI labels Feb 27, 2025
@bmhan12 bmhan12 self-assigned this Feb 27, 2025
@bmhan12 bmhan12 requested a review from rrsettgast as a code owner February 27, 2025 19:47
@bmhan12 bmhan12 changed the title [WIP] Add mathpresso to spack Docker containers [WIP] Add mathpresso to spack Feb 27, 2025
@bmhan12 bmhan12 mentioned this pull request Feb 27, 2025
Open
@bmhan12 bmhan12 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 27, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.32%. Comparing base (d9323f0) to head (f840cd8).

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop    #3575    +/-   ##
=========================================
  Coverage    56.31%   56.32%            
=========================================
  Files         1174     1178     +4     
  Lines       102601   102755   +154     
=========================================
+ Hits         57775    57872    +97     
- Misses       44826    44883    +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmhan12 bmhan12 changed the title [WIP] Add mathpresso to spack Add mathpresso to spack Feb 28, 2025
@bmhan12 bmhan12 force-pushed the feature/han12/spack_mathpresso branch from 142d8c5 to f840cd8 Compare February 28, 2025 22:17
@bmhan12 bmhan12 changed the title Add mathpresso to spack fix: Add mathpresso to spack Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bmhan12 bmhan12

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI type: build system Build system issue type: CI Concerns github workflows or generic CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bmhan12