Skip to content

Conversation

@vbuchard
Copy link
Contributor

@vbuchard vbuchard commented Dec 4, 2025

-Update of ana.rc.tmpl with NOAA 20 filename
-Update psas.rc with VIIRS names but also obs errors
•Buddy Check: m_sqc.F90 updated with openMP that works. Original code crashes with segmentation fault when turning on openMP. New code is 0 diff to the old code if you turn off openMP and 0 diff between openMP on/off
•GAAS_App/CMakeLists.txt: target_link_libraries(${this} PRIVATE OpenMP::OpenMP_Fortran)
•Needs setenv OMP_NUM_THREADS 20 (I tested with 20 and works quite fast)

•When running offline this appears: in ana_aod.csh:
                  # Running environment
                  # -------------------
                     set NCPUS = $cpu
                    limit  stack           unlimited
                    setenv ARCH uname -s
                    setenv PSAS_NUM_MPI    $NCPUS # for PSAS
                    setenv MPIRUN          "mpirun -np $PSAS_NUM_MPI"
                    setenv OMP_NUM_THREADS 20 # for SQC

Online: is it in ana_aod.j.tmpl? That setenv OMP_NUM_THREADS  should be added. Should it come from higher up.
 

@vbuchard vbuchard requested review from a team as code owners December 4, 2025 18:57
@vbuchard vbuchard added the 0 diff structural Structural changes to repository that are zero-diff label Dec 4, 2025
Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes work for me; and indeed give zero diff to results.

@rtodling rtodling merged commit 245a7b2 into develop Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff structural Structural changes to repository that are zero-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants