Skip to content

Sill under evaluation: remove redundancy #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtodling merged 1 commit into from
Feb 4, 2026
+4 −4
Merged

Sill under evaluation: remove redundancy #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gsibec/gsi/control2state.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,13 +294,13 @@ subroutine control2state(xhat,sval,bval)
call gsi_bundlegetpointer (wbundle,'q' ,cv_rh ,istatus)

! Get 3d pressure
if(do_getprs_tl) call getprs_tl(cv_ps,cv_t,sv_prse)
!_RT if(do_getprs_tl) call getprs_tl(cv_ps,cv_t,sv_prse)

! Convert input normalized RH to q
if(do_normal_rh_to_q) call normal_rh_to_q(cv_rh,cv_t,sv_prse,sv_q)

! Calculate sensible temperature
if(do_tv_to_tsen .and. .not.regional) call tv_to_tsen(cv_t,sv_q,sv_tsen)
!_RT if(do_tv_to_tsen .and. .not.regional) call tv_to_tsen(cv_t,sv_q,sv_tsen)

! Copy other variables
call gsi_bundlegetvar ( wbundle, 't' , sv_tv, istatus )
Expand Down
4 changes: 2 additions & 2 deletions src/gsibec/gsi/control2state_ad.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,14 +306,14 @@ subroutine control2state_ad(rval,bval,grad)
enddo
end if
! Calculate sensible temperature
if(do_tv_to_tsen_ad .and. .not.regional) call tv_to_tsen_ad(cv_t,rv_q,rv_tsen)
!_RT if(do_tv_to_tsen_ad .and. .not.regional) call tv_to_tsen_ad(cv_t,rv_q,rv_tsen)

! Adjoint of convert input normalized RH to q to add contribution of moisture
! to t, p , and normalized rh
if(do_normal_rh_to_q_ad) call normal_rh_to_q_ad(cv_rh,cv_t,rv_prse,rv_q)

! Adjoint to convert ps to 3-d pressure
if(do_getprs_ad) call getprs_ad(cv_ps,cv_t,rv_prse)
!_RT if(do_getprs_ad) call getprs_ad(cv_ps,cv_t,rv_prse)


!$omp section
Expand Down