Skip to content

Conversation

@Masanori-NOAA
Copy link
Contributor

This PR is for conducting regional fv3-jedi 3DVar analysis with qoption2. The specific code changes are as follows:

  • (c2710e5) : Found that the external subroutine “genqsat” failed to handle array inputs properly, affecting the background error of qoption2 normalized RH which dependent on background RH. After refactoring genqsat into a module, the background saturated specific humidity and RH distributions now align with expectations (see figures below).
image
  • (09e38be) : The oops generic interpolator does not extrapolate background values to analysis grid points located outside the LAM domain, leaving the values at these points undefined. To address this, added a process to fill these undefined points outside the model domain by copying background values from the nearest neighboring grid points.
  • (15890a4) : Changes to enable the use of RRFSv1 berror_stats (with usenewgfsberror = .true.).
  • (b5c88c6) : Fix related to 2nd outer loop crash in regional analysis
  • (cab79d9) : Refactoring to remove redundant code

@mathomp4 mathomp4 requested a review from rtodling December 17, 2025 17:02
@rtodling
Copy link
Collaborator

This is to say that I am aware of this PR and will devote time to looking at it soon.

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry: I am finally getting back to this and JEDI.

At first sight these changes look good.

I will run a quick test tomorrow and should be able to either approve - issue a tag - or provide any feedback needed.

@mathomp4 mathomp4 requested review from mathomp4 and rtodling February 3, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants