requested device tweaks #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove TODO assertion from get_trajectory_pfs_and_pbs function - Add test_trajectory_states_sink_consistency test to verify sink states and dummy actions consistency - This improves code organization by moving validation logic to tests Resolves the TODO comment about moving assertion to test file.
…ault, so we can make more effective use of compute by default and only run deterministically when explicitly requested by the user
refactor: move assertion from get_trajectory_pfs_and_pbs to test
changed performance mode to deterministic mode -- which is off by def…
…t new env developers, augmented documentation
…ts to pass debug to the env properly (and to handle this properly in the tests) - fixed one failing test.
Multinode experiments: improve wandb viz, fix n_modes computation, increase scoring function complexity
Optimize states and actions compute paths with `debug=False` mode in `Env`
Compile utility & benchmark
…ding move dummy/exit action to actions.py, changed comments in compile.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses requests by @younik