Dummy exit actions for graph building #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younik
approved these changes
Nov 28, 2025
Comment on lines
+378
to
+399
| # Required by the Actions base class for DB/SubTB style algorithms. | ||
| action_shape = (5,) | ||
| dummy_action = torch.tensor( | ||
| [ | ||
| GraphActionType.DUMMY, | ||
| -2, | ||
| -2, | ||
| -2, | ||
| -2, | ||
| ], | ||
| dtype=torch.long, | ||
| ) | ||
| exit_action = torch.tensor( | ||
| [ | ||
| GraphActionType.EXIT, | ||
| -1, | ||
| -1, | ||
| -1, | ||
| -1, | ||
| ], | ||
| dtype=torch.long, | ||
| ) |
Collaborator
There was a problem hiding this comment.
I think this should be defined directly in GraphActions then, as those values are fixed there
Collaborator
Author
There was a problem hiding this comment.
done in another pr (oops)
Comment on lines
+38
to
+43
| if module is None: | ||
| results[name] = False | ||
| continue | ||
|
|
||
| # If the estimator does not have a module, we cannot compile it. | ||
| try: |
Collaborator
There was a problem hiding this comment.
but we already checked above, so we can directly use module instead of try?
Collaborator
Author
There was a problem hiding this comment.
This is because sometimes compile just fails for some reason. I'm not really sure why this happens. torch.compile interacts with all sorts of things and im only starting to learn about how it works.
Collaborator
Author
|
oops, i merged another PR which I think included this one by mistake. ill address these changes now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a basic exit / dummy action which DB / SubTB can use