Multinode experiments: improve wandb viz, fix n_modes computation, increase scoring function complexity #447
+300
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdviviano
approved these changes
Dec 11, 2025
Collaborator
josephdviviano
left a comment
josephdviviano
left a comment
There was a problem hiding this comment.
looks good - thank you!
| dist.recv(score_tensor, src=self.remote_manager_rank) | ||
| score_dict = Message.deserialize(score_tensor).message_data | ||
|
|
||
| return score_dict |
Collaborator
There was a problem hiding this comment.
why is this a dict?
| 'pytorch==2.2' cpuonly \ | ||
| mkl -y | ||
|
|
||
| conda install gcc_linux-64 gxx_linux-64 gfortran_linux-64 impi_rt impi-devel intel-opencl-rt intel-openmp mpi4py oneccl_bind_pt oneccl intel-extension-for-pytorch |
Collaborator
There was a problem hiding this comment.
thanks - i need to finally clean this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the latest code I am using for my experiments (https://wandb.ai/torchgfn/torchgfn/reports/Scaling-number-of-policies-total-batch-size-1024--VmlldzoxNTMzMjI1OA)
It includes the new scoring function work (from @josephdviviano), the fix for the number of modes, and improved visualization for wandb (using grouping).