-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remaining border storages #1822
Merged
takb
merged 14 commits into
feat/config-wrapup
from
feat/config-wrapup-extended-storage-missing-borders
Jul 24, 2024
Merged
feat: Remaining border storages #1822
takb
merged 14 commits into
feat/config-wrapup
from
feat/config-wrapup-extended-storage-missing-borders
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
feat/config-wrapup-extended-storage-missing-borders
branch
2 times, most recently
from
July 23, 2024 14:57
8d5036d
to
729b433
Compare
This deserializer is able to create proper extended storage objects when deserializing the config.
This deserializer is able to create proper extended storage objects when deserializing the config.
MichaelsJP
force-pushed
the
feat/config-wrapup-extended-storage-missing-borders
branch
from
July 23, 2024 14:59
729b433
to
ba908fd
Compare
This serializer is able to serialize the ExtendedStorages. Without the serializer the resulting Json Strings would always include the duplicated Class name.
MichaelsJP
force-pushed
the
feat/config-wrapup-extended-storage-missing-borders
branch
from
July 24, 2024 12:43
4d32095
to
38d20d2
Compare
MichaelsJP
changed the title
feat: Add missing Borders Storage
feat: Missing border storages
Jul 24, 2024
MichaelsJP
changed the title
feat: Missing border storages
feat: Remaining border storages
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deserializer is able to create proper extended storage objects when deserializing the config.### Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)