Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remaining border storages #1822

Merged

Conversation

MichaelsJP
Copy link
Member

This deserializer is able to create proper extended storage objects when deserializing the config.### Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@MichaelsJP MichaelsJP force-pushed the feat/config-wrapup-extended-storage-missing-borders branch 2 times, most recently from 8d5036d to 729b433 Compare July 23, 2024 14:57
@MichaelsJP MichaelsJP force-pushed the feat/config-wrapup-extended-storage-missing-borders branch from 729b433 to ba908fd Compare July 23, 2024 14:59
@MichaelsJP MichaelsJP marked this pull request as ready for review July 23, 2024 14:59
@MichaelsJP MichaelsJP requested a review from takb July 23, 2024 14:59
@MichaelsJP MichaelsJP self-assigned this Jul 23, 2024
@github-actions github-actions bot added feature and removed feature labels Jul 23, 2024
@MichaelsJP MichaelsJP marked this pull request as draft July 23, 2024 15:17
This serializer is able to serialize the ExtendedStorages. Without the serializer the resulting Json Strings would always include the duplicated Class name.
@MichaelsJP MichaelsJP force-pushed the feat/config-wrapup-extended-storage-missing-borders branch from 4d32095 to 38d20d2 Compare July 24, 2024 12:43
@MichaelsJP MichaelsJP marked this pull request as ready for review July 24, 2024 12:47
@github-actions github-actions bot removed the feature label Jul 24, 2024
@MichaelsJP MichaelsJP changed the title feat: Add missing Borders Storage feat: Missing border storages Jul 24, 2024
@MichaelsJP MichaelsJP changed the title feat: Missing border storages feat: Remaining border storages Jul 24, 2024
@github-actions github-actions bot added feature and removed feature labels Jul 24, 2024
@takb takb merged commit cad9a07 into feat/config-wrapup Jul 24, 2024
18 of 21 checks passed
@takb takb deleted the feat/config-wrapup-extended-storage-missing-borders branch July 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

2 participants