Merged
Conversation
TheGreatRefrigerator
changed the title
sfendrich
force-pushed
the
refactor/move-buildIsochrones
branch
from
158bae8 to
885f10a
Compare
koebi
approved these changes
Dec 13, 2024
Collaborator
koebi
left a comment
koebi
left a comment
There was a problem hiding this comment.
LGTM :)
I really like these small steps - moving through them, commit by commit, makes it really easy to understand what is going on :)
What is the plan for TemporaryUtilShelter.java?
Further refactorings will show where the functions currently sheltering should live, I guess?
added 9 commits
December 14, 2024 00:04
This commit removes the second parameter `travellers` from method `IsochronesService.validateAgainstConfig(...)` This parameter is unnecessary because at the the only place, where this method is called, `travellers` is extracted from `isochroneRequest` just before the call. Hence this extraction can happen inside `validateAgainstConfig`.
Reduce the usage of `getTravellers()` where it is unnecessary.
Instead of injecting partial responses into the `isochronesRequest` on the fly, this commit first computes the whole response and injects it afterwards. This is a preparatory step to move the computation into `buildIsochrone`.
This commit moves the method `computeIsochrones` from `IsochronesService` into `RoutingProfileManager`and merges it with `buildIsochrones` by inlining. This is a preparatory step to move the for-loop of this method into `RoutingProfile.buildIsochrone`, which should then be moved into `IsochroneRequest`.
This commit moves the method `computeIsochrones` from `RoutingProfileManager` into `IsochroneRequest`.
sfendrich
force-pushed
the
refactor/move-buildIsochrones
branch
from
885f10a to
9a749aa
Compare
|
Contributor
Author
|
Thanks! The commits are already collections of small steps that belong together.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Information about the changes
Refactored RoutingProfile to improve maintainability