Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Gatling benchmarks #1978

Merged
merged 164 commits into from
Mar 24, 2025
Merged

perf: Gatling benchmarks #1978

merged 164 commits into from
Mar 24, 2025

Conversation

MichaelsJP
Copy link
Member

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

Sorry, something went wrong.

@github-actions github-actions bot added the test label Mar 10, 2025
@MichaelsJP MichaelsJP force-pushed the test/gatling-benchmark-rebase branch 2 times, most recently from 9b8e1a2 to d81ab5d Compare March 10, 2025 09:57
@MichaelsJP MichaelsJP changed the title test: gatling benchmark rebase test: gatling benchmark Mar 10, 2025
@github-actions github-actions bot added test and removed test labels Mar 10, 2025
@MichaelsJP MichaelsJP requested a review from takb March 10, 2025 09:58
@github-actions github-actions bot added test and removed test labels Mar 10, 2025
@MichaelsJP MichaelsJP force-pushed the test/gatling-benchmark-rebase branch from 3791915 to f15b218 Compare March 10, 2025 10:56
@MichaelsJP MichaelsJP force-pushed the test/gatling-benchmark-rebase branch from a892484 to 7219f30 Compare March 19, 2025 09:02
takb and others added 19 commits March 19, 2025 10:03
@takb @MichaelsJP
feat: initial gatling minimal setup
782d8a3
@takb @MichaelsJP
feat: read multiple points from CSV feed to construct points array
a354bc8
@MichaelsJP
feat: Add First CoordinateGenerator and tests and correct package name
715464b 
If the base url is set to openrouteservice.org and no api key set, a runtime exception is to be expected
@MichaelsJP
fix: Remove unnecessary instantiation
3d05e4a
@MichaelsJP
chore: Restructure functions
2f26b36
@takb @MichaelsJP
feat: batch processing scenarios
1f53a65
@MichaelsJP
feat: Add mockito response
767893f
@MichaelsJP
feat: Implement applyMatrix function
143bef0
@MichaelsJP
test(benchmark): Catch edge cases
8302e77 
Catch multiple null point exception possibilities etc.
Mockito needs some additional magic to properly log errors.
@Chwiggy @MichaelsJP
feat(benchmark): add method to create csv from coordinate results
765c112
@takb @MichaelsJP
fix: make configurable by env vars
8b9ef2b
@MichaelsJP
feat: Add writeToCSV
321a722
@MichaelsJP
fix: Adjust the matrixResults output
b20e7ef
@MichaelsJP
fix: Flip output column names to lon/lat
4657de0
@takb @MichaelsJP
fix: error message on conn fail
3d5eaf4
@takb @MichaelsJP
fix: use property for config
76a2a28
@takb @MichaelsJP
chore: update gatling to 3.13.4
89262e5
@MichaelsJP
fix: Address deprecated execute call
c545181
@MichaelsJP
chore: Migrate to mockito capture
1c57aa9
@MichaelsJP MichaelsJP force-pushed the test/gatling-benchmark-rebase branch from 1568545 to eaefbfa Compare March 19, 2025 10:12
MichaelsJP added 13 commits March 19, 2025 11:14
@MichaelsJP
fix: Remove duplicate overwrite
4812263
@MichaelsJP
chore: Avoid circular dependency
2e110d1 
The *Snapping.java and *Route.java class had a circular import pattern with their respective CLI classes. This is now broken up by excluding the main function code.
@MichaelsJP
refactor: Move utilities into a commonly shared place
9a91497
@MichaelsJP
refactor: Move config one level up into its own folder
d58a209
@MichaelsJP
refactor: Separate the command line tools from the generators
36126cd
@MichaelsJP
refactor: Rename the CLI classes to CommandLineParsers
aa3e91e
@MichaelsJP
refactor: Move the actual applications into the root folder as the ma…
11fe488 
…in entry points
@MichaelsJP
refactor: Rename the complicated app names to simpler ones.
229fd8b
@MichaelsJP
refactor: Move the generator related code to its own submodule and th…
27d79f5 
…e benchmark to its own.
@MichaelsJP
docs: Adjust the benchmark documentation
cb45032
@MichaelsJP
docs: Remove outdated parameter and update documentation
13cf944
@MichaelsJP
docs: Add Coordinate Generators documentation
a05ad54
@MichaelsJP
docs: Add API Benchmarks documentation
f886d3f
@MichaelsJP MichaelsJP marked this pull request as ready for review March 19, 2025 14:55
@github-actions github-actions bot added test and removed test labels Mar 19, 2025
@MichaelsJP MichaelsJP changed the title test: gatling benchmark perf: gatling benchmark Mar 19, 2025
@MichaelsJP MichaelsJP changed the title perf: gatling benchmark perf: Gatling benchmarks Mar 19, 2025
@MichaelsJP MichaelsJP force-pushed the test/gatling-benchmark-rebase branch from ece5d40 to 71bf0d0 Compare March 19, 2025 14:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

takb
takb approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@takb takb merged commit 0a20258 into main Mar 24, 2025
32 checks passed
@takb takb deleted the test/gatling-benchmark-rebase branch March 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takb takb

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelsJP @takb @Chwiggy