Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastisochrones multirangefix #916

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Fastisochrones multirangefix #916

merged 5 commits into from
Apr 28, 2021

Conversation

HendrikLeuschner
Copy link
Collaborator

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the app.config file, I have added these to the app.config wiki page on github along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the importer etc.), I have generated longer distance routes for the affected profiles with different options (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end points generated from the current live ORS. If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes # .

Information about the changes

  • Key functionality added: Changed calculation of multiple range fast isochrones
  • Reason for change: Problems arising from reusing parts of inner ranges when calculating outer ranges. Now every range is calculated individually with the inner ranges just added as additional input data.

Examples and reasons for differences between live ORS routes and those generated from this pull request

Required changes to app.config (if applicable)

@HendrikLeuschner HendrikLeuschner added the bug Erroneous behavior of the backend label Apr 27, 2021
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@takb takb merged commit 87a8620 into master Apr 28, 2021
@TheGreatRefrigerator TheGreatRefrigerator deleted the fastisochrones_multirangefix branch August 2, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behavior of the backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants