Remove some signature_versions from coins definitions#1523
Remove some signature_versions from coins definitions#1523mariocynicys wants to merge 2 commits intoGLEECBTC:masterfrom
signature_versions from coins definitions#1523Conversation
Removed 'signature_version' field from multiple coin configurations. For `FRC`, `CRNC` & `MAZA`, such config wasn't needed since it's already implied because we have no "fork_id" set for them. For `CAS`, `AVN` & `LCC`, those are kept as is because the signature_version config actually has a purpose. If we remove the `signature_version: "base"` from there, those coins will default to `signature_version: "fork_id"` since the "fork_id" option is set for those coins. `LCC-segwit` configuration looks confusing. The signature version is set to `"base"` and it has a `"fork_id"` option set, but arguablly, these options are all useless in signing because segwit coins always get signed as `"WitnessV0"`.
make sure to set all `signature_version`s for all `fork_id: 0x40` chains to avoid confusion. normally, for a `fork_id: 0x40` chain, if the `signature_version` is not set, it defaults to `signature_version: "fork_id"`. this commit just makes this behaviour explicit.
|
for but i will leave |
|
@mariocynicys can you please propose testing for this PR? E.g. KDF method & expected outcome etc. |
|
For coins that remove For the coins that add explicit For coins that remove |
Removed
signature_versionfields from multiple coin configurations.For
FRC,CRNC&MAZA, such config wasn't needed since it's already implied because we have no"fork_id": "0x40"set for them.For
CAS,AVN&LCC, those are kept as is because thesignature_versionconfig actually has a purpose. If we remove thesignature_version: "base"from there, those coins will default tosignature_version: "fork_id"since the"fork_id": "0x40"option is set for those coins.LCC-segwitconfiguration looks confusing. The signature version is set to"base"and it has a"fork_id": "0x40"option set, but arguablly, these options are all useless in signing because segwit coins always get signed as"WitnessV0".