fix(ci): stabilize release candidate checks#3468
Conversation
|
Visit the preview URL for this PR (updated for commit da7293b): https://walletrc--pull-3468-merge-5ki0rtip.web.app (expires Sat, 04 Apr 2026 21:54:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da7293b780
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| FLUTTER_XCODE_CODE_SIGN_IDENTITY: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '' || '' }} | ||
| FLUTTER_XCODE_CODE_SIGN_STYLE: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && 'Manual' || '' }} | ||
| FLUTTER_XCODE_DEVELOPMENT_TEAM: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '' || '' }} | ||
| FLUTTER_XCODE_PROVISIONING_PROFILE_SPECIFIER: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '' || '' }} |
There was a problem hiding this comment.
Restrict blank FLUTTER_XCODE overrides to PR builds
In .github/workflows/desktop-builds.yml (build step env block), these FLUTTER_XCODE_* assignments evaluate to an empty string for all events, not just pull requests. Because Flutter forwards FLUTTER_XCODE_* variables to xcodebuild, release-triggered runs (on: release) can receive explicit blank signing settings, which may override the provisioning/certificate setup from setup-macos and cause unsigned or failed macOS release artifacts. These variables should be omitted outside PR builds rather than exported as empty values.
Useful? React with 👍 / 👎.
Summary
Fix the failing CI checks blocking #3461:
FLUTTER_XCODE_*Xcode overridesValidation
dart format test_integration/runners/integration_test_runner.dartflutter analyze --no-fatal-warnings --no-fatal-infosdart run komodo_wallet_build_transformer --fetch_defi_api --artifact_output_package=komodo_defi_framework --config_output_path=app_build/build_config.json -i assets/transformer_invoker.txt -o assets/transformer_invoker.txtflutter build macos --releasewithFLUTTER_XCODE_*overrides confirmed the old provisioning failure is gone; the remaining local failure is the known single-build asset-transform rerun path that CI already works around in.github/actions/generate-assets