Skip to content

fix(ci): stabilize release candidate checks#3468

Merged
CharlVS merged 8 commits into
devfrom
fix/pr-3461-ci
Mar 28, 2026
Merged

fix(ci): stabilize release candidate checks#3468
CharlVS merged 8 commits into
devfrom
fix/pr-3461-ci

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Mar 28, 2026

Summary

Fix the failing CI checks blocking #3461:

  • bootstrap the SDK workspace before CI analysis so generated SDK files exist
  • fetch native KDF artifacts explicitly for iOS/macOS setup before platform builds
  • update the web integration runner for Flutter 3.41 CLI changes
  • disable macOS PR signing using Flutter-supported FLUTTER_XCODE_* Xcode overrides
  • install missing LLVM/binutils tooling in the Linux Docker build image
  • make the validate workflow fail on analyzer errors only, not the existing warning/info backlog

Validation

  • dart format test_integration/runners/integration_test_runner.dart
  • flutter analyze --no-fatal-warnings --no-fatal-infos
  • dart run komodo_wallet_build_transformer --fetch_defi_api --artifact_output_package=komodo_defi_framework --config_output_path=app_build/build_config.json -i assets/transformer_invoker.txt -o assets/transformer_invoker.txt
  • local flutter build macos --release with FLUTTER_XCODE_* overrides confirmed the old provisioning failure is gone; the remaining local failure is the known single-build asset-transform rerun path that CI already works around in .github/actions/generate-assets

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 28, 2026

Visit the preview URL for this PR (updated for commit da7293b):

https://walletrc--pull-3468-merge-5ki0rtip.web.app

(expires Sat, 04 Apr 2026 21:54:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS marked this pull request as ready for review March 28, 2026 22:27
@CharlVS CharlVS merged commit 9fcf415 into dev Mar 28, 2026
15 of 16 checks passed
@CharlVS CharlVS deleted the fix/pr-3461-ci branch March 28, 2026 22:28
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da7293b780

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +86 to +89
FLUTTER_XCODE_CODE_SIGN_IDENTITY: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '' || '' }}
FLUTTER_XCODE_CODE_SIGN_STYLE: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && 'Manual' || '' }}
FLUTTER_XCODE_DEVELOPMENT_TEAM: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '' || '' }}
FLUTTER_XCODE_PROVISIONING_PROFILE_SPECIFIER: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '' || '' }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict blank FLUTTER_XCODE overrides to PR builds

In .github/workflows/desktop-builds.yml (build step env block), these FLUTTER_XCODE_* assignments evaluate to an empty string for all events, not just pull requests. Because Flutter forwards FLUTTER_XCODE_* variables to xcodebuild, release-triggered runs (on: release) can receive explicit blank signing settings, which may override the provisioning/certificate setup from setup-macos and cause unsigned or failed macOS release artifacts. These variables should be omitted outside PR builds rather than exported as empty values.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant