Merged
Conversation
…into spv_proof
- native client should not return error on validate_spv_proof since there is no verification
…into spv_proof
…into spv_proof
…into spv_proof
sergeyboyko0791
left a comment
sergeyboyko0791
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Last comments :)
| fn ticker(&self) -> &str; | ||
|
|
||
| fn block_headers_storage(&self) -> Option<BlockHeaderStorage> { | ||
| let params = json::from_value(self.conf()["block_header_params"].clone()).ok()?; |
There was a problem hiding this comment.
Could you please return an error if we couldn't parse block_header_params?
fn block_headers_storage(&self) -> UtxoCoinBuildResult <Option<BlockHeaderStorage>> {
let params: Option<_> = json::from_value(self.conf()["block_header_params"].clone())?;
match params {
Some(params) => BlockHeaderStorage::new_from_ctx(self.ctx().clone(), params),
None => Ok(None)
}
}
|
@Milerius Is it ready for the next review iteration? |
Author
I'm currently checking on #1207 (comment) other than that yes. edit: #1207 (comment) I confirm that we need to keep an Option for the block header storage, every coins doesn't need a storage for block headers, it depends if the option is set or not in the conf file - ready for review. |
artemii235
suggested changes
Mar 21, 2022
artemii235
left a comment
artemii235
left a comment
There was a problem hiding this comment.
Few minor code improvements proposals.
|
@shamardy @sergeyboyko0791 Please check if all your comments are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spv_validationcrate with validation functions forheadersandtransactionnightly-2022-02-01validate_paymentvalidate_paymentvalidate_spvreturn immediatly Ok in native mode.is_aarch64_feature_detected!undersimd_aarch64feature rust-lang/stdarch#1239&usage, I've usedclippy::allowto bypass them.