[r2r] Lightning Swaps Locktimes + Lightning Maker Swap#1557
Merged
sergeyboyko0791 merged 22 commits intodevfrom Dec 8, 2022
Merged
[r2r] Lightning Swaps Locktimes + Lightning Maker Swap#1557sergeyboyko0791 merged 22 commits intodevfrom
sergeyboyko0791 merged 22 commits intodevfrom
Conversation
…e that generated the invoice, add unit tests for this case
…er swap locktime for other coin 1.5x taker swap locktime
shamardy
changed the title
shamardy
changed the title
shamardy
requested review from
artemii235,
caglaryucekaya,
onur-ozkan and
sergeyboyko0791
sergeyboyko0791
suggested changes
Nov 28, 2022
sergeyboyko0791
left a comment
sergeyboyko0791
left a comment
There was a problem hiding this comment.
Awesome as usual!
I have mostly questions due to the algorithm complexity
shamardy
changed the title
…_log_with_msg when we need to log info too
shamardy
changed the title
caglaryucekaya
previously approved these changes
Dec 6, 2022
caglaryucekaya
left a comment
caglaryucekaya
left a comment
There was a problem hiding this comment.
Great work 🔥 I only have a few minor notes and some questions
mm2src/coins/lightning.rs
Outdated
| Ok(()) | ||
| }, | ||
| Ok(None) => MmError::err(ValidatePaymentError::UnexpectedPaymentState(format!( | ||
| "Payment {} should be found on the database", |
There was a problem hiding this comment.
How about "Payment {} could not be found on the database"
Collaborator
Author
There was a problem hiding this comment.
Because the error variant is UnexpectedPaymentState, I wanted to highlight the expected state in the error message. At this stage (validating a swap payment), the payment info should be in the database. I can modify the message to be
"Payment {} is not in the database when it should be"What do you think?
shamardy
changed the title
shamardy
dismissed stale reviews from caglaryucekaya and sergeyboyko0791
via
de0fa05
shamardy
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1045