forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 117
feat(swap): cancel maker order for offline coins #2357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
borngraced
wants to merge
38
commits into
dev
Choose a base branch
from
cancel-offline-electrum-orders
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+201
−140
Draft
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
eac9f81
save dev state
borngraced 3618ddd
fix string termination err
borngraced 6a48ca2
add is_active flag for MakerOrder
borngraced d2b8cff
add todos and fill is_active flag for MakerOrder initializations
borngraced 98f53cc
pause maker others from matching if coin relies on electrum conns
borngraced ca7190f
remove todo comment and unneeded if-else
borngraced 6420d94
remove unused
borngraced 55e7f7a
nit
borngraced c4e458e
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced 5818720
update flag to is_offline
borngraced d58d2c0
fix cargo clippy
borngraced 029c457
update order log info for offline orders
borngraced 2e33e90
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced b7ef6c3
use enum for MakerOrder status
borngraced e18f60b
fix clippy warnings
borngraced 44ce1a9
rename MakerOrderStatus enum variants
borngraced 94c5111
update docs
borngraced 5997e23
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced eedc9b9
cancel order, refactor save_my_t/maker_order
borngraced e598eb2
improve order cancelling logic, cover all coin/protocols and improve …
borngraced bfa7720
fix bug
borngraced fb2b4fe
fix bch
borngraced be73fa3
fix z_coin_cache db path in best_orders_tests
borngraced 37ae831
use current_block to check eth server status
borngraced 65296a6
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced 928520e
remove unnecessary line breaks
borngraced ba36f6c
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced 5ef3858
fix review notes
borngraced f49e339
nits
borngraced 6287556
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced 0fa2ba8
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced f505257
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced 18e3c87
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced a4bea76
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced c18e4af
Merge branch 'dev' into cancel-offline-electrum-orders
borngraced 9306a25
merge with origin/dev
shamardy 7c7f370
post merge fix
shamardy d75abc7
merge with origin/dev
shamardy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be annotated/cfg-ed for tests only. this breaks
cargo check.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done thanks.