feat(db-arch): implement global DB uuid to address_dir map#2466
Draft
mariocynicys wants to merge 15 commits intodevfrom
Draft
feat(db-arch): implement global DB uuid to address_dir map#2466mariocynicys wants to merge 15 commits intodevfrom
mariocynicys wants to merge 15 commits intodevfrom
Conversation
…address but only of the address wasn't already passed by the caller
…t time i.e. in `insert_new_swap_to_db`
the gist of this commit lies in mm2_main::database::my_swaps. `fn insert_new_swap` now takes a connection and writes that swap to. this connection is passed from the caller, and it's the address_db that's derived from the maker coin address. for old arch this essentially brings no change. the same db from dbdir() is still the one used in this case.
and ofc we need to use create_parents in the calls that use the output of such path. also based on the note about colons having to be escaped on windows, similar fix was put in address_dir utility function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the global DB's UUID -> maker_address mapping.
When the swap is started or imported (via
import_swapsrpc), the uuid to maker_address mapping gets stored in the global DB. When the uuid is queried, we fetch the maker_address from that global DB map to get the address directory that hosts the data related to that uuid.This touches only v1 swaps for now.