fix(ci): fix CI test failures for 3.0.0-beta release#2718
Merged
Conversation
walletd v2.12.0 (via coreutils v0.20.0) added sanityCheckNetwork() which enforces hardfork heights must be in chronological order. Our CI network config had hardforkV2.allowHeight=0 which violates the rule "v2 hardfork must not precede Foundation hardfork" (height 30). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shamardy
force-pushed
the
fix/3.0.0-beta-ci-fixes
branch
from
f5dd377 to
78becba
Compare
walletd's debug/mine endpoint returns after blocks are applied to consensus, but address balance indexing runs asynchronously in a background goroutine. The previous 100ms fixed sleep was a race condition that became unreliable with walletd v2.12.0. Replace with a polling loop that retries until the balance is visible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The old endpoint (34.80.202.172:26657) is no longer reachable. Replace with the official nyancat testnet RPC at rpc.nyancat.irisnet.org. Some tests that reference pruned historical tx hashes may still fail and will need fresh transactions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…actions Replace pruned historical tx hashes with fresh on-chain transactions on IRIS nyancat-9 testnet. All 8 previously failing Tendermint unit tests now pass with new fixture data including successful transfers, HTLC create/claim/refund operations, and intentionally failed transactions. Add ignored test_create_nyancat_fixtures test for reproducible fixture generation when transactions get pruned again in the future. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shamardy
changed the title
shamardy
added a commit
that referenced
this pull request
Mar 9, 2026
…o-dev chore(release): propagate #2718 (staging→dev)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI failures from #2717 (3.0.0-beta staging merge).
1. Sia container crash
walletd v2.12.0 (coreutils v0.20.0) added
sanityCheckNetwork()requiring hardfork heights in chronological order. Our config hadhardforkV2.allowHeight=0which violatesv2 hardfork must not precede Foundation hardfork(height 30). SetallowHeightto30.2. Sia flaky balance test
test_sia_client_address_balanceused a fixed 100ms sleep after mining. walletd'sdebug/minereturns after consensus applies blocks, but address balance indexing runs asynchronously in a background goroutine (wallet/manager.go syncStore). Replaced with a polling loop.3. IRIS testnet endpoint dead
All Tendermint unit tests used
http://34.80.202.172:26657which is no longer reachable. Updated to the official nyancat-9 RPC athttps://rpc.nyancat.irisnet.org.4. Tendermint test fixtures pruned
8 unit tests referenced historical tx hashes that were pruned by the nyancat-9 node (
earliest_block_height: 25800001). Created fresh on-chain transactions:Added an ignored
test_create_nyancat_fixturestest for reproducible fixture generation when transactions get pruned again in the future.CI Failures from #2717
allowHeightconfig + balance pollingTest plan
cargo clippy -p coins --testsclean🤖 Generated with Claude Code