Skip to content

sync main #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ca333 merged 2 commits into from
Nov 1, 2025
Merged

sync main #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf0075
add optional verbose logging
ca333 Nov 1, 2025
0cdff3c
Merge pull request #278 from KomodoPlatform/optional_logging
ca333 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/komodo_defi_framework/lib/komodo_defi_framework.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import 'package:logging/logging.dart';
export 'package:komodo_defi_framework/src/client/kdf_api_client.dart';
export 'package:komodo_defi_framework/src/config/event_streaming_config.dart';
export 'package:komodo_defi_framework/src/config/kdf_config.dart';
export 'package:komodo_defi_framework/src/config/kdf_logging_config.dart';
export 'package:komodo_defi_framework/src/config/kdf_startup_config.dart';
export 'package:komodo_defi_framework/src/services/seed_node_service.dart';
export 'package:komodo_defi_framework/src/streaming/event_streaming_service.dart';
Expand Down
77 changes: 43 additions & 34 deletions packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/bch_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:convert';
import 'dart:developer' show log;

import 'package:komodo_defi_framework/komodo_defi_framework.dart';
import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart';
import 'package:komodo_defi_sdk/src/activation/_activation.dart';
import 'package:komodo_defi_types/komodo_defi_types.dart';
Expand Down Expand Up @@ -93,20 +94,22 @@ class BchActivationStrategy extends ProtocolActivationStrategy {
[];

// Debug logging for BCH activation
log(
'[RPC] Activating BCH platform: ${asset.id.id}',
name: 'BchActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'slp_token_count': children?.length ?? 0,
'slp_tokens': children?.map((e) => e.id.id).toList() ?? [],
'activation_params': bchConfig.toRpcParams(),
})}',
name: 'BchActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating BCH platform: ${asset.id.id}',
name: 'BchActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'slp_token_count': children?.length ?? 0,
'slp_tokens': children?.map((e) => e.id.id).toList() ?? [],
'activation_params': bchConfig.toRpcParams(),
})}',
name: 'BchActivationStrategy',
);
}

// Enable BCH with SLP support
final response = await client.rpc.slp.enableBchWithTokens(
Expand All @@ -115,10 +118,12 @@ class BchActivationStrategy extends ProtocolActivationStrategy {
slpTokensRequests: slpTokensRequests,
);

log(
'[RPC] Successfully activated BCH with ${children?.length ?? 0} SLP tokens',
name: 'BchActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Successfully activated BCH with ${children?.length ?? 0} SLP tokens',
name: 'BchActivationStrategy',
);
}

yield ActivationProgress(
status: 'Verifying activation...',
Expand Down Expand Up @@ -156,28 +161,32 @@ class BchActivationStrategy extends ProtocolActivationStrategy {
);

// Debug logging for SLP token activation
log(
'[RPC] Activating SLP token: ${asset.id.id}',
name: 'BchActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'parent_id': asset.id.parentId?.id,
})}',
name: 'BchActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating SLP token: ${asset.id.id}',
name: 'BchActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'parent_id': asset.id.parentId?.id,
})}',
name: 'BchActivationStrategy',
);
}

await client.rpc.slp.enableSlpToken(
ticker: asset.id.id,
params: SlpActivationParams(),
);

log(
'[RPC] Successfully activated SLP token: ${asset.id.id}',
name: 'BchActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Successfully activated SLP token: ${asset.id.id}',
name: 'BchActivationStrategy',
);
}

yield ActivationProgress.success(
details: ActivationProgressDetails(
Expand Down
41 changes: 23 additions & 18 deletions ...odo_defi_sdk/lib/src/activation/protocol_strategies/custom_erc20_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:convert';
import 'dart:developer' show log;

import 'package:komodo_defi_framework/komodo_defi_framework.dart';
import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart';
import 'package:komodo_defi_sdk/src/activation/_activation.dart';
import 'package:komodo_defi_types/komodo_defi_type_utils.dart';
Expand Down Expand Up @@ -70,20 +71,22 @@ class CustomErc20ActivationStrategy extends ProtocolActivationStrategy {
final contractAddress = protocolData.value<String>('contract_address');

// Debug logging for custom ERC20 token activation
log(
'[RPC] Activating custom ERC20 token: ${asset.id.id}',
name: 'CustomErc20ActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'platform': platform,
'contract_address': contractAddress,
'activation_params': activationParams.toRpcParams(),
})}',
name: 'CustomErc20ActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating custom ERC20 token: ${asset.id.id}',
name: 'CustomErc20ActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'platform': platform,
'contract_address': contractAddress,
'activation_params': activationParams.toRpcParams(),
})}',
name: 'CustomErc20ActivationStrategy',
);
}

await client.rpc.erc20.enableCustomErc20Token(
ticker: asset.id.id,
Expand All @@ -92,10 +95,12 @@ class CustomErc20ActivationStrategy extends ProtocolActivationStrategy {
contractAddress: contractAddress,
);

log(
'[RPC] Successfully activated custom ERC20 token: ${asset.id.id}',
name: 'CustomErc20ActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Successfully activated custom ERC20 token: ${asset.id.id}',
name: 'CustomErc20ActivationStrategy',
);
}

yield ActivationProgress.success(
details: ActivationProgressDetails(
Expand Down
41 changes: 23 additions & 18 deletions ...ges/komodo_defi_sdk/lib/src/activation/protocol_strategies/erc20_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:convert';
import 'dart:developer' show log;

import 'package:komodo_defi_framework/komodo_defi_framework.dart';
import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart';
import 'package:komodo_defi_sdk/src/activation/_activation.dart';
import 'package:komodo_defi_types/komodo_defi_types.dart';
Expand Down Expand Up @@ -71,30 +72,34 @@ class Erc20ActivationStrategy extends ProtocolActivationStrategy {
);

// Debug logging for ERC20 token activation
log(
'[RPC] Activating ERC20 token: ${asset.id.id}',
name: 'Erc20ActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'parent_id': asset.id.parentId?.id,
'activation_params': activationParams.toRpcParams(),
'priv_key_policy': privKeyPolicy.toJson(),
})}',
name: 'Erc20ActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating ERC20 token: ${asset.id.id}',
name: 'Erc20ActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
'parent_id': asset.id.parentId?.id,
'activation_params': activationParams.toRpcParams(),
'priv_key_policy': privKeyPolicy.toJson(),
})}',
name: 'Erc20ActivationStrategy',
);
}

await client.rpc.erc20.enableErc20(
ticker: asset.id.id,
activationParams: activationParams,
);

log(
'[RPC] Successfully activated ERC20 token: ${asset.id.id}',
name: 'Erc20ActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Successfully activated ERC20 token: ${asset.id.id}',
name: 'Erc20ActivationStrategy',
);
}

yield ActivationProgress.success(
details: ActivationProgressDetails(
Expand Down
29 changes: 17 additions & 12 deletions .../komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_task_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:convert';
import 'dart:developer' show log;
import 'package:komodo_defi_framework/komodo_defi_framework.dart';

import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart';
import 'package:komodo_defi_sdk/src/activation/_activation.dart';
Expand Down Expand Up @@ -93,24 +94,28 @@ class EthTaskActivationStrategy extends ProtocolActivationStrategy {
);

// Debug logging for ETH task-based activation
log(
'[RPC] Activating ETH platform (task-based): ${asset.id.id}',
name: 'EthTaskActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({'ticker': asset.id.id, 'protocol': asset.protocol.subClass.formatted, 'token_count': children?.length ?? 0, 'tokens': children?.map((e) => e.id.id).toList() ?? [], 'activation_params': activationParams.toRpcParams(), 'priv_key_policy': privKeyPolicy.toJson()})}',
name: 'EthTaskActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating ETH platform (task-based): ${asset.id.id}',
name: 'EthTaskActivationStrategy',
);
log(
'[RPC] Activation parameters: ${jsonEncode({'ticker': asset.id.id, 'protocol': asset.protocol.subClass.formatted, 'token_count': children?.length ?? 0, 'tokens': children?.map((e) => e.id.id).toList() ?? [], 'activation_params': activationParams.toRpcParams(), 'priv_key_policy': privKeyPolicy.toJson()})}',
name: 'EthTaskActivationStrategy',
);
}

final taskResponse = await client.rpc.erc20.enableEthInit(
ticker: asset.id.id,
params: activationParams,
);

log(
'[RPC] Task initiated for ${asset.id.id}, task_id: ${taskResponse.taskId}',
name: 'EthTaskActivationStrategy',
);
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Task initiated for ${asset.id.id}, task_id: ${taskResponse.taskId}',
name: 'EthTaskActivationStrategy',
);
}

yield ActivationProgress(
status: 'Establishing network connections...',
Expand Down
13 changes: 10 additions & 3 deletions ..._defi_sdk/lib/src/activation/protocol_strategies/eth_with_tokens_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:convert';
import 'dart:developer' show log;
import 'package:komodo_defi_framework/komodo_defi_framework.dart';

import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart';
import 'package:komodo_defi_sdk/src/activation/_activation.dart';
Expand Down Expand Up @@ -114,24 +115,30 @@ class EthWithTokensActivationStrategy extends ProtocolActivationStrategy {
);

// Debug logging for ETH platform activation
log(
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating ETH platform: ${asset.id.id}',
name: 'EthWithTokensActivationStrategy',
);
log(
}
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activation parameters: ${jsonEncode({'ticker': asset.id.id, 'protocol': asset.protocol.subClass.formatted, 'token_count': children?.length ?? 0, 'tokens': children?.map((e) => e.id.id).toList() ?? [], 'activation_params': activationParams.toRpcParams(), 'priv_key_policy': privKeyPolicy.toJson()})}',
name: 'EthWithTokensActivationStrategy',
);
}
Comment on lines +118 to +129
Copy link

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two consecutive log statements are wrapped in separate if (KdfLoggingConfig.verboseLogging) blocks. These should be combined into a single conditional block to reduce redundancy and improve readability.

Copilot uses AI. Check for mistakes.

await client.rpc.erc20.enableEthWithTokens(
ticker: asset.id.id,
params: activationParams,
);

log(
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Successfully activated ETH platform: ${asset.id.id} with ${children?.length ?? 0} tokens',
name: 'EthWithTokensActivationStrategy',
);
}

yield const ActivationProgress(
status: 'Finalizing activation...',
Expand Down
13 changes: 10 additions & 3 deletions ...ages/komodo_defi_sdk/lib/src/activation/protocol_strategies/qtum_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:convert';
import 'dart:developer' show log;
import 'package:komodo_defi_framework/komodo_defi_framework.dart';

import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart';
import 'package:komodo_defi_sdk/src/activation/_activation.dart';
Expand Down Expand Up @@ -45,11 +46,14 @@ class QtumActivationStrategy extends ProtocolActivationStrategy {
);

// Debug logging for QTUM activation
log(
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activating QTUM coin: ${asset.id.id}',
name: 'QtumActivationStrategy',
);
log(
}
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Activation parameters: ${jsonEncode({
Comment on lines +49 to 57
Copy link

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two consecutive log statements are wrapped in separate if (KdfLoggingConfig.verboseLogging) blocks. These should be combined into a single conditional block to reduce redundancy and improve readability.

Copilot uses AI. Check for mistakes.
'ticker': asset.id.id,
'protocol': asset.protocol.subClass.formatted,
Expand All @@ -58,16 +62,19 @@ class QtumActivationStrategy extends ProtocolActivationStrategy {
})}',
name: 'QtumActivationStrategy',
);
}

final taskResponse = await client.rpc.qtum.enableQtumInit(
ticker: asset.id.id,
params: activationParams,
);

log(
if (KdfLoggingConfig.verboseLogging) {
log(
'[RPC] Task initiated for ${asset.id.id}, task_id: ${taskResponse.taskId}',
name: 'QtumActivationStrategy',
);
}

var isComplete = false;
while (!isComplete) {
Expand Down
Loading
Loading