Skip to content

Normalizes the OHLC days parameter #288

Open
smk762 wants to merge 1 commit into
devfrom
fix/snap-ohlc
Open

Normalizes the OHLC days parameter #288
smk762 wants to merge 1 commit into
devfrom
fix/snap-ohlc

Conversation

@smk762
Copy link
Copy Markdown
Contributor

@smk762 smk762 commented Nov 12, 2025

closes #287

Snaps the days param for coingecko api ohlc queries to accepted values.

To test:

  • launch app in web with dev console open.
  • filter network logs to capture coingecko requests
  • navigate around graphs and ensure no errors as seen in linked issue are present.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/snap-ohlc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 linked an issue Nov 12, 2025 that may be closed by this pull request
@smk762 smk762 self-assigned this Nov 12, 2025
@smk762 smk762 added the P1 Major issue that needs to be fixed label Nov 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 2f1f1b3):

https://komodo-playground--pr288-fix-snap-ohlc-s1jrvtjf.web.app

(expires Wed, 19 Nov 2025 05:22:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 2f1f1b3):

https://kdf-sdk--pr288-fix-snap-ohlc-w36u4wmw.web.app

(expires Wed, 19 Nov 2025 05:23:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d

Copy link
Copy Markdown

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 Major issue that needs to be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid Coingecko API OHLC request for days param value

2 participants