Skip to content

fix(macos): support release and CI KDF artefacts#347

Draft
CharlVS wants to merge 1 commit intodevfrom
fix/macos-kdf-finding
Draft

fix(macos): support release and CI KDF artefacts#347
CharlVS wants to merge 1 commit intodevfrom
fix/macos-kdf-finding

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Apr 2, 2026

Summary

  • normalize macOS KDF archives into a canonical layout before marking them current
  • prefer GitHub release libkdf-* artefacts first, while still accepting CI/mirror kdf-* artefacts when they validate
  • update the macOS podspec to support executable, dylib, and static-library packaging with one code path

Root Cause

The macOS release artefact for KDF commit d56a7bc is published as libkdf-macos-universal2-<hash>.zip and contains libkdflib.a, but the active Flutter plugin podspec only accepted bin/kdf or lib/libkdflib.dylib. That made release-candidate builds fail even though compatible CI-style executable archives still existed on mirrors.

Impact

  • macOS builds now work with both GitHub release and CI-built KDF artefacts
  • GitHub releases remain the primary source of truth by source order and filename preference
  • incompatible macOS archives fall through to the next source instead of surfacing later as an Xcode failure

Validation

  • dart test in packages/komodo_wallet_build_transformer
  • dart analyze lib/src/native/kdf_executable_finder.dart lib/src/operations/kdf_operations_native.dart in packages/komodo_defi_framework
    • only pre-existing infos remained in those two files

@CharlVS CharlVS changed the title [codex] fix(macos): support release and CI KDF artefacts fix(macos): support release and CI KDF artefacts Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Visit the preview URL for this PR (updated for commit 46bd73f):

https://komodo-playground--pr347-fix-macos-kdf-findin-wac4cduw.web.app

(expires Thu, 09 Apr 2026 18:02:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant