fix(macos): support release and CI KDF artefacts#347
Draft
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit 46bd73f): https://komodo-playground--pr347-fix-macos-kdf-findin-wac4cduw.web.app (expires Thu, 09 Apr 2026 18:02:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libkdf-*artefacts first, while still accepting CI/mirrorkdf-*artefacts when they validateRoot Cause
The macOS release artefact for KDF commit
d56a7bcis published aslibkdf-macos-universal2-<hash>.zipand containslibkdflib.a, but the active Flutter plugin podspec only acceptedbin/kdforlib/libkdflib.dylib. That made release-candidate builds fail even though compatible CI-style executable archives still existed on mirrors.Impact
Validation
dart testinpackages/komodo_wallet_build_transformerdart analyze lib/src/native/kdf_executable_finder.dart lib/src/operations/kdf_operations_native.dartinpackages/komodo_defi_framework