Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Workflow Improvements #263

Open
Isopod00 opened this issue Jul 3, 2024 · 2 comments
Open

GitHub Actions Workflow Improvements #263

Isopod00 opened this issue Jul 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Isopod00
Copy link
Member

Isopod00 commented Jul 3, 2024

Suggested GitHub Actions Workflow Improvements:

  • Add C++ linting to the super-linter action we already use for python (maybe other languages too? like YAML, XML, and bash?)
  • Test colcon build to make sure key packages build (probably not necessary though as it would take a long time?)
  • It might be interesting to look into using this GitHub Action in a workflow for automated build & deployment of our dev container image: https://github.com/marketplace/actions/build-and-push-docker-images
@Isopod00 Isopod00 added the enhancement New feature or request label Jul 3, 2024
@jmblixt3
Copy link
Member

jmblixt3 commented Jul 14, 2024

  1. You can c++ linting just match the ros standard
  2. For bash linting use shellcheck

@jmblixt3
Copy link
Member

jmblixt3 commented Jul 18, 2024

Also instead of just failing as an action make it fix the issues with a new commit for lint errors

@Isopod00 Isopod00 self-assigned this Jul 18, 2024
@jmblixt3 jmblixt3 added this to the DevOps and DevEnv milestone Aug 27, 2024
@Isopod00 Isopod00 removed their assignment Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants