Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the refresh rate precision. (AMDVLK #268) #100

Closed
wants to merge 1 commit into from
Closed

Conversation

qiaojbao
Copy link
Collaborator

No description provided.

@amdvlk-admin
Copy link
Collaborator

6b7e722 Jenkins build error.
/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/pal-github-pr/driver_build/drivers/xgl/icd/api/vk_physical_device.cpp:9477:76: error: no match for ‘operator*’ (operand types are ‘Pal::Rational’ {aka ‘Util::Rational’} and ‘int’)
9477 | properties[i].parameters.refreshRate = pScreenMode[i]->refreshRate * 1000;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
| | |
| | int
| Pal::Rational {aka Util::Rational}

/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/pal-github-pr/driver_build/drivers/xgl/icd/api/vk_physical_device.cpp:9541:90: error: no match for ‘operator*’ (operand types are ‘Pal::Rational’ {aka ‘Util::Rational’} and ‘int’)
9541 | (pCreateInfo->parameters.refreshRate == pScreenMode[i]->refreshRate * 1000))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
| | |
| | int
| Pal::Rational {aka Util::Rational}
/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/pal-github-pr/driver_build/drivers/xgl/icd/api/vk_physical_device.cpp:9572:77: error: no match for ‘operator=’ (operand types are ‘Pal::Rational’ {aka ‘Util::Rational’} and ‘const uint32_t’ {aka ‘const unsigned int’})
9572 | pNewMode->palScreenMode.refreshRate = pCreateInfo->parameters.refreshRate;
| ^~~~~~~~~~~
In file included from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/pal-github-pr/driver_build/drivers/pal/inc/core/./palFormat.h:34,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/pal-github-pr/driver_build/drivers/pal/inc/core/./pal.h:34,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/pal-github-pr/driver_build/drivers/pal/inc/core/./palPlatform.h:34,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants